Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 13383: HIVE-4545 - HS2 should return describe table results without space padding


Copy link to this message
-
Re: Review Request 13383: HIVE-4545 - HS2 should return describe table results without space padding
Thejas Nair 2013-08-07, 19:18

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13383/
-----------------------------------------------------------

(Updated Aug. 7, 2013, 7:18 p.m.)
Review request for hive.
Changes
-------

HIVE-4545.3.patch - updates test case to remove .trim() before comparison in two more places.
Bugs: HIVE-4545
    https://issues.apache.org/jira/browse/HIVE-4545
Repository: hive-git
Description
-------

HIVE-3140 changed behavior of 'DESCRIBE table;' to be like 'DESCRIBE FORMATTED table;'. HIVE-3140 introduced changes to not print header in 'DESCRIBE table;'. But jdbc/odbc calls still get fields padded with space for the 'DESCRIBE table;' query.

As the jdbc/odbc results are not for direct human consumption the space padding should not be done for hive server2.
Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 83f337b
  jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java f35a351
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4dcb260
  ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java a85a19d
  ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java 0d71891
  ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 4c40034
  ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0f48674
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7254491

Diff: https://reviews.apache.org/r/13383/diff/
Testing
-------

Updated TestJdbcDriver2 unit tests
Thanks,

Thejas Nair