Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Re: Review Request: Changes for PIG-3321


Copy link to this message
-
Re: Review Request: Changes for PIG-3321

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11155/#review20547
-----------------------------------------------------------

http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java
<https://reviews.apache.org/r/11155/#comment42386>

    userSpecifiedInputAvroSchema - just to make reading code easier.

http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java
<https://reviews.apache.org/r/11155/#comment42387>

    This is a protected method. Moving it would break code if someone is extending this class. Can you still leave this method and make this one call AvroStorageUtil.getSchema

http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java
<https://reviews.apache.org/r/11155/#comment42389>

    Can we do this for same and schema_uri too?

http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroDatumReader.java
<https://reviews.apache.org/r/11155/#comment42391>

    Why is this temporary array required when data is already being read in in.readFieldOrder() ? Am I missing something?

http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java
<https://reviews.apache.org/r/11155/#comment42390>

    Shouldn't it be input data schema? Or we can call it reader schema only.

http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
<https://reviews.apache.org/r/11155/#comment42392>

    writerSchema = readerSchema
- Rohini Palaniswamy
On May 14, 2013, 10:18 p.m., Harvey Chong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11155/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 10:18 p.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Changes for https://issues.apache.org/jira/browse/PIG-3321
>
> Overview:
> AvroStorage.java - If 'schema' argument is passed to constructor, use it as the reader schema on load.  Moved getSchema() to AvroStorageUtils and made public+static, so it can be called from PigAvroRecordReader.
> AvroStorageUtils.java - Moved getSchema() here.
> PigAvroInputFormat.java - nothing functional here, just renamed 'schema' to 'readerSchema' for clarity.
> PigAvroRecordReader.java - The constructor now determines the writer schema for its split, and passes both reader and writer schema to the PigAvroDatumReader constructor, which will allow the Avro code to resolve the two.
> PigAvroDatumReader.java - Changed readRecord() to add entries to the output Tuple in writer order rather than reader order.
> TestAvroStorage.java - Added a new testcase for user specified schema in load.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1482017
>   http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1482017
>   http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroDatumReader.java 1482017
>   http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1482017
>   http://svn.apache.org/repos/asf/pig/branches/branch-0.11/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1482017