Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'


+
Mengwei Ding 2013-05-30, 03:14
+
Mengwei Ding 2013-05-30, 03:14
+
Abraham Elmahrek 2013-05-30, 05:23
+
Abraham Elmahrek 2013-05-30, 21:23
+
Mengwei Ding 2013-05-30, 21:23
+
Mengwei Ding 2013-05-30, 21:23
+
Jarek Cecho 2013-06-02, 14:23
+
Jarek Cecho 2013-06-03, 17:41
+
Mengwei Ding 2013-06-03, 16:52
+
Jarek Cecho 2013-06-02, 14:24
+
Mengwei Ding 2013-06-03, 16:50
+
Mengwei Ding 2013-06-04, 23:22
+
Jarek Cecho 2013-06-05, 00:27
+
Mengwei Ding 2013-06-05, 16:55
Copy link to this message
-
Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'


> On June 5, 2013, 12:27 a.m., Jarek Cecho wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java, lines 60-65
> > <https://reviews.apache.org/r/11535/diff/2/?file=300854#file300854line60>
> >
> >     I'm wondering what will happen when user will specify both --webapp and --url at the same time. Do you think that it would make sense to address this edge case?
>
> Mengwei Ding wrote:
>     Yes, this is a good one. Currently according to the code, the value for --url would cover the value for --webapp if both of them have been specified. I think it's good to allow user setting the value in only one unique way instead of multiple ones, which will of course make confusions. Or else, I could do something to forbid the appearance of both of them.

Yeah agreed, we should prevent usage of both ways at the same time as it will be quite confusing.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11535/#review21450
-----------------------------------------------------------
On June 4, 2013, 11:22 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11535/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:22 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 67ccd56d492ac4910c28376f7be0bcaad4e5cbdb
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed May 29 18:04:53 2013 -0700
>
>     SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'
>
> :100644 100644 979b892... 68d9740... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 1c85592... c2581c3... M client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
> :100644 100644 5dbcef5... 9f9289e... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 e328f9a... 2e91630... M client/src/main/resources/client-resource.properties
> :100644 100644 33419b9... 2434a96... M docs/src/site/sphinx/CommandLineClient.rst
>
>
> This addresses bug SQOOP-973.
>     https://issues.apache.org/jira/browse/SQOOP-973
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 979b892
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java 1c85592
>   client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 5dbcef5
>   client/src/main/resources/client-resource.properties e328f9a
>   docs/src/site/sphinx/CommandLineClient.rst 33419b9
>
> Diff: https://reviews.apache.org/r/11535/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>

+
Mengwei Ding 2013-06-04, 23:09
+
Mengwei Ding 2013-06-04, 23:10
+
Mengwei Ding 2013-06-04, 22:22
+
Mengwei Ding 2013-06-05, 18:01
+
Jarek Cecho 2013-06-05, 21:19
+
Mengwei Ding 2013-06-05, 21:24