-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9300/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

Added defensive code to skip the HBase put and warn the user if it has no columns and would therefore fail.
Before this change it was crashing the whole Sqoop job.
This addresses bug SQOOP-862.
    https://issues.apache.org/jira/browse/SQOOP-862
Diffs
-----

  src/java/org/apache/sqoop/hbase/HBasePutProcessor.java cca641f
  src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java bf24608
  src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 65ff87b

Diff: https://reviews.apache.org/r/9300/diff/
Testing
-------

Tested manually and created a new automated test for this case.
Thanks,

David Robson

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9300/#review16248
-----------------------------------------------------------
Hi David,
thank you very much for filling this bug and providing patch. Would you mind adding sentence or two into the user guide documenting the behaviour?

Jarcec

- Jarek Cecho
On Feb. 5, 2013, 3:56 a.m., David Robson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9300/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 3:56 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Added defensive code to skip the HBase put and warn the user if it has no columns and would therefore fail.
> Before this change it was crashing the whole Sqoop job.
>
>
> This addresses bug SQOOP-862.
>     https://issues.apache.org/jira/browse/SQOOP-862
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java cca641f
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java bf24608
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 65ff87b
>
> Diff: https://reviews.apache.org/r/9300/diff/
>
>
> Testing
> -------
>
> Tested manually and created a new automated test for this case.
>
>
> Thanks,
>
> David Robson
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9300/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 9:45 p.m.)
Review request for Sqoop.
Changes
-------

Added change to documentation.
Description
-------

Added defensive code to skip the HBase put and warn the user if it has no columns and would therefore fail.
Before this change it was crashing the whole Sqoop job.
This addresses bug SQOOP-862.
    https://issues.apache.org/jira/browse/SQOOP-862
Diffs (updated)
-----

  src/docs/user/hbase.txt 7404929
  src/java/org/apache/sqoop/hbase/HBasePutProcessor.java cca641f
  src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java bf24608
  src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 65ff87b

Diff: https://reviews.apache.org/r/9300/diff/
Testing
-------

Tested manually and created a new automated test for this case.
Thanks,

David Robson

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9300/#review16325
-----------------------------------------------------------

Ship it!
Ship It!

- Jarek Cecho
On Feb. 7, 2013, 9:45 p.m., David Robson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9300/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2013, 9:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Added defensive code to skip the HBase put and warn the user if it has no columns and would therefore fail.
> Before this change it was crashing the whole Sqoop job.
>
>
> This addresses bug SQOOP-862.
>     https://issues.apache.org/jira/browse/SQOOP-862
>
>
> Diffs
> -----
>
>   src/docs/user/hbase.txt 7404929
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java cca641f
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java bf24608
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 65ff87b
>
> Diff: https://reviews.apache.org/r/9300/diff/
>
>
> Testing
> -------
>
> Tested manually and created a new automated test for this case.
>
>
> Thanks,
>
> David Robson
>
>