-Re: update on dist exec work
Jacques Nadeau 2013-04-19, 16:11
Couple quick notes:
- DrillConfig: You import VideoTrackSizeListener. I think this probably
just an accident
- DrillClient: You should pass null rather than an empty buffer.
Otherwise we have to encode and decode a buffer of length zero. If no
buffer is passed, we just drop that field all together. Also, I wasn't
thinking that the second submitQuery() exists. The goal of the buffer
field is to be able to keep data off heap. We probably shouldn't use it
for for metadata (such as the query plan).
- drill-module.conf: you've added a user.address. What is this for?
- In SystemSystemTestBase you go about updating the port numbers in the
config. I was thinking that it would be preferred that the RPC system
simply started with the initial binding ports and then worked their way
north until they found an available one. Thoughts? That way it doesn't
take special configuration to run multiple Drillbits simultaneously (for
Otherwise look great! Let me know about the items above and then I'll
merge into the WIP. My goal is for us to get the WIP to a certain state
then have a more set of substantial reviews before we commit to default.
On Thu, Apr 18, 2013 at 8:18 PM, David Alves <[EMAIL PROTECTED]> wrote:
> Hi All
> I just submitted a pr (
> https://github.com/apache/incubator-drill/pull/16) agains the execwork
> that does the following:
> - fixed the bug in hazelcache where it would always try to start a
> new cluster (now checks if one exists first)
> - fixed the bug in zk coordinator where endpoints wouldn't get
> refreshed prior to a cluster change (why it was failing before)
> - added a DrillClient wrapper class that does the lookup through
> - added a base sys test class that starts an embedded zk cluster
> and starts multiple drillbits
> - removed sleep() in Driillbit startup and separated Drillbit
> startup form the main() method.
> - added a toString() DrillConfig
> If you're working on dist exec please take the new
> DrillSystemTestBase for a spin (boots up a mini zk cluster and a Drillbit
> cluster), a good example is DrillClientSystemTest.
> It'd be cool if we could use that to have repeatable tests.
> Let me know is anything is a miss.