HBase, mail # dev - Re: HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT

HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT

Ted Yu 2012-12-21, 23:22

Hi,
There are two constants with the same value:
HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT

HConstants.ZOOKEEPER_SESSION_TIMEOUT is only used in tests.
HConstants.ZK_SESSION_TIMEOUT is used by ZKUtil

Shall we remove HConstants.ZOOKEEPER_SESSION_TIMEOUT and let tests use
HConstants.ZK_SESSION_TIMEOUT ?

Cheers

Re: HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT

Nick Dimiduk 2012-12-21, 23:47

Yes please!

On Fri, Dec 21, 2012 at 3:22 PM, Ted Yu <[EMAIL PROTECTED]> wrote:

> Hi,
> There are two constants with the same value:
> HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT
>
> HConstants.ZOOKEEPER_SESSION_TIMEOUT is only used in tests.
> HConstants.ZK_SESSION_TIMEOUT is used by ZKUtil
>
> Shall we remove HConstants.ZOOKEEPER_SESSION_TIMEOUT and let tests use
> HConstants.ZK_SESSION_TIMEOUT ?
>
> Cheers
>

Re: HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT

Jonathan Hsieh 2012-12-22, 05:29

+1. file, fix, and since trivial, I'd say feel free to commit.

Jon.

On Fri, Dec 21, 2012 at 3:22 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> Hi,
> There are two constants with the same value:
> HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT
>
> HConstants.ZOOKEEPER_SESSION_TIMEOUT is only used in tests.
> HConstants.ZK_SESSION_TIMEOUT is used by ZKUtil
>
> Shall we remove HConstants.ZOOKEEPER_SESSION_TIMEOUT and let tests use
> HConstants.ZK_SESSION_TIMEOUT ?
>
> Cheers

--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// [EMAIL PROTECTED]

Re: HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT

Nick Dimiduk 2012-12-26, 19:31

I opened HBASE-7428 to track this. A patch is now available.

-n

On Fri, Dec 21, 2012 at 9:29 PM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote:

> +1. file, fix, and since trivial, I'd say feel free to commit.
>
> Jon.
>
> On Fri, Dec 21, 2012 at 3:22 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> > Hi,
> > There are two constants with the same value:
> > HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT
> >
> > HConstants.ZOOKEEPER_SESSION_TIMEOUT is only used in tests.
> > HConstants.ZK_SESSION_TIMEOUT is used by ZKUtil
> >
> > Shall we remove HConstants.ZOOKEEPER_SESSION_TIMEOUT and let tests use
> > HConstants.ZK_SESSION_TIMEOUT ?
> >
> > Cheers
>
>
>
> --
> // Jonathan Hsieh (shay)
> // Software Engineer, Cloudera
> // [EMAIL PROTECTED]
>