Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request 12201: SQOOP-1114 Sqoop2: Integration: Add tests for various Generic JDBC Connector splitters


+
Jarek Cecho 2013-06-30, 18:25
+
Hari Shreedharan 2013-07-12, 00:32
+
Jarek Cecho 2013-07-12, 00:36
Copy link to this message
-
Re: Review Request 12201: SQOOP-1114 Sqoop2: Integration: Add tests for various Generic JDBC Connector splitters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12201/
-----------------------------------------------------------

(Updated July 30, 2013, 3:21 a.m.)
Review request for Sqoop.
Changes
-------

Changes:

* Rebased on current head of Sqoop2 branch.
* Incorporated Hari's feedback by counting number of output files
* Improved the test case by calling several different splitters
* Currently the integration test is failing on SQOOP-1113
Bugs: SQOOP-1114
    https://issues.apache.org/jira/browse/SQOOP-1114
Repository: sqoop-sqoop2
Description
-------

I've added new test case that is testing most of splitters available in Generic JDBC Connector. For those tests I've prepared new testing data set that is based on Ubuntu releases and updated junit to version 4.11 for better Parameterized runner.
Diffs (updated)
-----

  pom.xml 520c107662ff1215820369d873daa25289ce492f
  test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java 056e6124b918ce5821c389e388a0cdfa68fd7fc0
  test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java PRE-CREATION
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java bf1c91f21784cbb57a4d5f07711ad57deaaf3f7d
  test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java ca77e64486d80b38306b5b30e185e6278ad7eaf1
  test/src/main/java/org/apache/sqoop/test/utils/ParametrizedUtils.java PRE-CREATION
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/imports/PartitionerTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/12201/diff/
Testing
-------

2 out of 4 new tests are currently failing, both appear to be code (and not test) issues, so I've filled SQOOP-1112 and SQOOP-1113 to deal with them separately.
Thanks,

Jarek Cecho

+
Jarek Cecho 2013-07-30, 04:10
+
Hari Shreedharan 2013-07-30, 20:53
+
Hari Shreedharan 2013-07-30, 20:54
+
Jarek Cecho 2013-07-30, 22:00
+
Hari Shreedharan 2013-07-31, 06:27