-
Re: Is there any reason not to make org.apache.pig.Main.getVersionString() public?Gianmarco De Francisci Mo... 2011-11-15, 09:55
+1
I see no reason why it should be private.
Also, why do we try/catch throwing a RuntimeException which is Bad™?
I think a client can reasonably recover from not finding the version string.
Cheers,
--
Gianmarco
On Tue, Nov 15, 2011 at 05:44, Jonathan Coveney <[EMAIL PROTECTED]> wrote:
> And perhaps also add getVersionNumberString() which is just "0.11.0" or
> whatever? I can imagine some helper methods that might be convenient...I
> have been working on a version migration in Pig and this would be
> convenient to have, and it seems like there is no real reason to hide this
> from the user.
>
> Thoughts?
>
I see no reason why it should be private.
Also, why do we try/catch throwing a RuntimeException which is Bad™?
I think a client can reasonably recover from not finding the version string.
Cheers,
--
Gianmarco
On Tue, Nov 15, 2011 at 05:44, Jonathan Coveney <[EMAIL PROTECTED]> wrote:
> And perhaps also add getVersionNumberString() which is just "0.11.0" or
> whatever? I can imagine some helper methods that might be convenient...I
> have been working on a version migration in Pig and this would be
> convenient to have, and it seems like there is no real reason to hide this
> from the user.
>
> Thoughts?
>
