Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request: HIVE-4637 Fix VectorUDAFSum.txt to honor the expected vector column type


Copy link to this message
-
Re: Review Request: HIVE-4637 Fix VectorUDAFSum.txt to honor the expected vector column type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11579/#review21250
-----------------------------------------------------------
It seems VectorUDAFAvg.txt also has the same issue. It might be a good idea to fix similar issue in other templates too.

- Jitendra Pandey
On May 31, 2013, 2:39 p.m., Remus Rusanu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11579/
> -----------------------------------------------------------
>
> (Updated May 31, 2013, 2:39 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> See HIVE-4637
>
>
> This addresses bug HIVE-4637.
>     https://issues.apache.org/jira/browse/HIVE-4637
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFSumDouble.java a2e8fb3
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java 3ef2aa8
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFSum.txt aaaa6ad
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java 6fc230f
>
> Diff: https://reviews.apache.org/r/11579/diff/
>
>
> Testing
> -------
>
> Added new UT to cover this case
>
>
> Thanks,
>
> Remus Rusanu
>
>