Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase >> mail # dev >> Review Request: Improvements to prewarm META cache


Copy link to this message
-
Re: Review Request: Improvements to prewarm META cache

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/78/#review91
-----------------------------------------------------------

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment515>

    Remove the spurious spaces around the parenthesis.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment516>

    No space before `[]' on this line and the previous line.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment517>

    Move the declaration of this variable to line 675 where it's initialized.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment518>

    I'm not sure I understand this comment but it could be because I'm not very familiar with this part of the code.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment519>

    Do this instead:
    
    if (value == null) {
      return true;  // don't cache it
    }
    final String serverAddress = Bytes.toString(value);

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment520>

    I don't understand the last part of the comment ("fetch ahead number of rows in META").

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment521>

    No space before `[]'.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment522>

    Wrap the `else' on the previous line.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment523>

    Instead of doing `+ e.getMessage()', pass `e' in second argument.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment524>

    No space before `[]'.

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.hbase.org/r/78/#comment525>

    Remove the second part of the check (tableLogs.values() == null).  This can't happen.  If it happens, there's a bug in SoftValueSortedMap and we shouldn't hide it.

src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
<http://review.hbase.org/r/78/#comment526>

    No space before `[]'.
- Benoit
On 2010-05-23 15:40:17, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/78/
> -----------------------------------------------------------
>
> (Updated 2010-05-23 15:40:17)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> Posting review board for this JIRA on behalf of Mingjie Lai
>
>
> This addresses bug HBASE-2468.
>     http://issues.apache.org/jira/browse/HBASE-2468
>
>
> Diffs
> -----
>
>   src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 09de2ac
>   src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 3de661e
>   src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 95e494a
>
> Diff: http://review.hbase.org/r/78/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Todd
>
>