Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request: Change ORC tree readers to return batches of rows instead of a row


Copy link to this message
-
Re: Review Request: Change ORC tree readers to return batches of rows instead of a row

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10712/#review19581
-----------------------------------------------------------
Incomplete review - I had only a few minutes to look at it this morning and I don't know the context, so this is just a couple of typos I noticed in sampling the code.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/DynamicByteArray.java
<https://reviews.apache.org/r/10712/#comment40439>

    Presumably totalLenght should be totalLength?

ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
<https://reviews.apache.org/r/10712/#comment40440>

    If noNulls should be true only when there are nulls present, shouldn't the login here work the other way around - noNulls starting true and going false when you encounter a null?
- Scott Preece
On April 22, 2013, 10:26 p.m., Sarvesh Sakalanaga wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10712/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 10:26 p.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> The patch contains changes to ORC reader to return a batch of rows instead of a row. A new method called nextBatch() is added to ORC reader and tree readers of ORC. Currently only int,long,short,double,float,string and struct support batch processing.
>
>
> This addresses bug HIVE-4370.
>     https://issues.apache.org/jira/browse/HIVE-4370
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java 246170d
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/DynamicByteArray.java fc4e53b
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReader.java 05240ce
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java d044cd8
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerReader.java 2825c64
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sarvesh Sakalanaga
>
>