Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-480 MS SQL server connector is incompatible with Sqoop-1.4


Copy link to this message
-
Re: Review Request: SQOOP-480 MS SQL server connector is incompatible with Sqoop-1.4

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4972/
-----------------------------------------------------------

(Updated 2012-05-27 20:02:25.273901)
Review request for Sqoop, Bilung Lee and Jarek Cecho.
Summary
-------

Sqoop-1.4.* is incompatible with Microsoft SQL server connector due to the namespace migration from com.cloudera to org.apache.

The changes include:
1) Add a wrapper method setConnManager(com.cloudera.sqoop.manager.ConnManager) to ImportJobContext.
2) Enhance SQL server manager test so that it can be used with Microsoft connector as well.
This addresses bug SQOOP-480.
    https://issues.apache.org/jira/browse/SQOOP-480
Diffs
-----

  /build.xml 1333179
  /src/java/com/cloudera/sqoop/manager/ImportJobContext.java 1333179
  /src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1333179

Diff: https://reviews.apache.org/r/4972/diff
Testing
-------

1) Ran 'ant test -Dtestcase=SQLServerManagerImportManualTest' with both built-in SQL connector and Microsoft connector.
2) Ran 'ant test', 'ant test -Dthirdparty=true', and 'ant checkstyle'.
Thanks,

Cheolsoo