-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9071/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've moved initialization and destroyer logic to newly created class SqoopServer.
This addresses bug SQOOP-850.
    https://issues.apache.org/jira/browse/SQOOP-850
Diffs
-----

  core/src/main/java/org/apache/sqoop/core/SqoopServer.java PRE-CREATION
  server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 5998e01e9b7388d561b16079dedbf9ab808aad85

Diff: https://reviews.apache.org/r/9071/diff/
Testing
-------

Unit tests seems to be passing and I've run simple import on real cluster.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9071/#review15899
-----------------------------------------------------------
I found the method names are swapped. Is this intentional or a mistake?
core/src/main/java/org/apache/sqoop/core/SqoopServer.java
<https://reviews.apache.org/r/9071/#comment34174>

    Isn't this method called destroy?

core/src/main/java/org/apache/sqoop/core/SqoopServer.java
<https://reviews.apache.org/r/9071/#comment34175>

    Isn't this method called intialize?

server/src/main/java/org/apache/sqoop/server/ServerInitializer.java
<https://reviews.apache.org/r/9071/#comment34176>

    Shouldn't we call SqoopServer.destory()?

server/src/main/java/org/apache/sqoop/server/ServerInitializer.java
<https://reviews.apache.org/r/9071/#comment34177>

    Shouldn't we call SqoopServer.initialize()?
- Cheolsoo Park
On Jan. 23, 2013, 7:56 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9071/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 7:56 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've moved initialization and destroyer logic to newly created class SqoopServer.
>
>
> This addresses bug SQOOP-850.
>     https://issues.apache.org/jira/browse/SQOOP-850
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java PRE-CREATION
>   server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 5998e01e9b7388d561b16079dedbf9ab808aad85
>
> Diff: https://reviews.apache.org/r/9071/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've run simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

> On Jan. 30, 2013, 11:29 p.m., Cheolsoo Park wrote:
> > I found the method names are swapped. Is this intentional or a mistake?

Hi Cheolsoo,
thank you very much for your review and catching this embarrassing bug.

Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9071/#review15899
-----------------------------------------------------------
On Jan. 31, 2013, 4:43 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9071/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 4:43 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've moved initialization and destroyer logic to newly created class SqoopServer.
>
>
> This addresses bug SQOOP-850.
>     https://issues.apache.org/jira/browse/SQOOP-850
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java PRE-CREATION
>   server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 5998e01e9b7388d561b16079dedbf9ab808aad85
>
> Diff: https://reviews.apache.org/r/9071/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've run simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9071/
-----------------------------------------------------------

(Updated Jan. 31, 2013, 4:43 p.m.)
Review request for Sqoop.
Changes
-------

I've incorporated the changes suggested by Cheolsoo.
Description
-------

I've moved initialization and destroyer logic to newly created class SqoopServer.
This addresses bug SQOOP-850.
    https://issues.apache.org/jira/browse/SQOOP-850
Diffs (updated)
-----

  core/src/main/java/org/apache/sqoop/core/SqoopServer.java PRE-CREATION
  server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 5998e01e9b7388d561b16079dedbf9ab808aad85

Diff: https://reviews.apache.org/r/9071/diff/
Testing
-------

Unit tests seems to be passing and I've run simple import on real cluster.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9071/#review15944
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Jan. 31, 2013, 4:43 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9071/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 4:43 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've moved initialization and destroyer logic to newly created class SqoopServer.
>
>
> This addresses bug SQOOP-850.
>     https://issues.apache.org/jira/browse/SQOOP-850
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java PRE-CREATION
>   server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 5998e01e9b7388d561b16079dedbf9ab808aad85
>
> Diff: https://reviews.apache.org/r/9071/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've run simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>