Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 15166: ACCUMULO-802 Tablespaces


Copy link to this message
-
Re: Review Request 15166: ACCUMULO-802 Tablespaces


> On Nov. 1, 2013, 10:19 p.m., John Vines wrote:
> > server/master/src/main/java/org/apache/accumulo/master/Master.java, line 953
> > <https://reviews.apache.org/r/15166/diff/1/?file=376147#file376147line953>
> >
> >     I think we should have dedicated thrift returns for these. Or at least dedicated thrift error codes
>
> Sean Hickey wrote:
>     Ya, I wasn't sure how to handle that exactly. Looking back at the code, there is a TableNotFoundException that's a Thrift Exception, so we should probably just make a similar one for namespaces.
>
> Christopher Tubbs wrote:
>     This is internal implementation details. It's currently functioning, and I don't think it should hold up the feature. I'm dropping this.

I've been comparing and I think some of the exceptions should be in line with invalid table names, of which it is actually. So I'll file a separate ticket for that, I guess.

However, Rename has a catch for NamespaceNotFoundException, but nothing in the Repo creation throws a NamespaceNotFoundException, so there's a bug there. All the other table operations which catch it are good though.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15166/#review28029
-----------------------------------------------------------
On Nov. 1, 2013, 2:01 a.m., Christopher Tubbs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15166/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 2:01 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-802
>     https://issues.apache.org/jira/browse/ACCUMULO-802
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-802 Tablespaces (Table Namespaces), work done by Sean Hickey, https://github.com/Wisellama/accumulo/tree/ACCUMULO-802, rebase'd onto latest master (including 210 commits)
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/accumulo/core/Constants.java 9db0c405c5b9fbac13fa735c3ffd6433e9831051
>   core/src/main/java/org/apache/accumulo/core/client/Connector.java bbfa55f4b9ad8fc0e5f0c0058e2e0564685d7c85
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceExistsException.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceNotEmptyException.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceNotFoundException.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperations.java 86a3ff271fc2e085c426da3156cfab9cdbb5c36b
>   core/src/main/java/org/apache/accumulo/core/client/admin/SecurityOperationsImpl.java 0f0e998f334631cfb342f9a39fdd12e62aa98f13
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperationsHelper.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperationsImpl.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1b652f99e23e2dfa06c7373a6f4c3c044f5cd1a3
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java bd1156912849b13ebad8f6b974fd35d8adf18f1d
>   core/src/main/java/org/apache/accumulo/core/client/impl/TableNamespaces.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/impl/Tables.java 8bc725a3405a79c20c690bff3f6fdb6f713be523
>   core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 488e0654720250542145e0d543ad16813f8d8b6d
>   core/src/main/java/org/apache/accumulo/core/client/impl/thrift/SecurityErrorCode.java b706ce87bb1e8a525e585b14b7fb8563c3493c2c
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 5ee144d9eb67c8e79dad870abbd823cac64e111e