Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function


Copy link to this message
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Alexander Alten-Lorenz 2013-03-11, 07:10

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9842/#review17683
-----------------------------------------------------------

flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java
<https://reviews.apache.org/r/9842/#comment37555>

    Please remove the spaces and tabs.

flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java
<https://reviews.apache.org/r/9842/#comment37556>

    Please remove the spaces and tabs.

flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/9842/#comment37557>

    Please remove the spaces and tabs.

flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/9842/#comment37558>

    Please remove empty line.

flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/9842/#comment37559>

    Please remove the spaces.

flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/9842/#comment37560>

    Please remove the spaces.

flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/9842/#comment37561>

    Please remove the spaces.

flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/9842/#comment37562>

    Please remove the spaces and tabs.
- Alexander Alten-Lorenz
On March 10, 2013, 10:48 p.m., Ambud Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9842/
> -----------------------------------------------------------
>
> (Updated March 10, 2013, 10:48 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Ref: https://issues.apache.org/jira/browse/FLUME-1938
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464
>
> Diff: https://reviews.apache.org/r/9842/diff/
>
>
> Testing
> -------
>
> Functional test done resulting in full message body being written to file.
>
>
> Thanks,
>
> Ambud Sharma
>
>