|
|
-
Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-03-10, 22:46
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- Review request for Flume. Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing ------- Functional test with full message body. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-03-10, 22:48
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- (Updated March 10, 2013, 10:48 p.m.) Review request for Flume. Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing (updated) ------- Functional test done resulting in full message body being written to file. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-03-12, 14:20
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- (Updated March 12, 2013, 2:20 p.m.) Review request for Flume. Changes ------- Fixed tabs and spaces Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs (updated) ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing ------- Functional test done resulting in full message body being written to file. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Alexander Alten-Lorenz 2013-03-14, 06:53
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review17861----------------------------------------------------------- What do your think to rename MultilineBody into SyslogMultiLineBody? flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java < https://reviews.apache.org/r/9842/#comment37824> space or empty line, please remove - Alexander Alten-Lorenz On March 12, 2013, 2:20 p.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9842/> ----------------------------------------------------------- > > (Updated March 12, 2013, 2:20 p.m.) > > > Review request for Flume. > > > Description > ------- > > Ref: https://issues.apache.org/jira/browse/FLUME-1938 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 > > Diff: https://reviews.apache.org/r/9842/diff/> > > Testing > ------- > > Functional test done resulting in full message body being written to file. > > > Thanks, > > Ambud Sharma > >
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-03-14, 07:10
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- (Updated March 14, 2013, 7:10 a.m.) Review request for Flume. Changes ------- Changed variable names from MultilineBody to SyslogMultiLineBody, fixed space Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs (updated) ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing ------- Functional test done resulting in full message body being written to file. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-03-14, 07:15
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- (Updated March 14, 2013, 7:14 a.m.) Review request for Flume. Changes ------- Extra space discovered in diff. Fixed now Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs (updated) ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing ------- Functional test done resulting in full message body being written to file. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-03-14, 07:17
> On March 14, 2013, 6:53 a.m., Alexander Alten-Lorenz wrote: > > What do your think to rename MultilineBody into SyslogMultiLineBody? I have changed the variable and constant names accordingly. Please let me know if the patch looks ok now? Als, do I need to provide a corresponding "config" document for setting the multi-line property true in flume.conf? - Ambud ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review17861----------------------------------------------------------- On March 14, 2013, 7:14 a.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9842/> ----------------------------------------------------------- > > (Updated March 14, 2013, 7:14 a.m.) > > > Review request for Flume. > > > Description > ------- > > Ref: https://issues.apache.org/jira/browse/FLUME-1938 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 > > Diff: https://reviews.apache.org/r/9842/diff/> > > Testing > ------- > > Functional test done resulting in full message body being written to file. > > > Thanks, > > Ambud Sharma > >
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Alexander Alten-Lorenz 2013-03-14, 09:20
> On March 14, 2013, 6:53 a.m., Alexander Alten-Lorenz wrote: > > What do your think to rename MultilineBody into SyslogMultiLineBody? > > Ambud Sharma wrote: > I have changed the variable and constant names accordingly. Please let me know if the patch looks ok now? > > Als, do I need to provide a corresponding "config" document for setting the multi-line property true in flume.conf? Yes, please update the config section in our documentation. The patch looks okay (for me). Thanks for your effort! I'll review when the doc part is done too ;) - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review17861----------------------------------------------------------- On March 14, 2013, 7:14 a.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9842/> ----------------------------------------------------------- > > (Updated March 14, 2013, 7:14 a.m.) > > > Review request for Flume. > > > Description > ------- > > Ref: https://issues.apache.org/jira/browse/FLUME-1938 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 > > Diff: https://reviews.apache.org/r/9842/diff/> > > Testing > ------- > > Functional test done resulting in full message body being written to file. > > > Thanks, > > Ambud Sharma > >
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Alexander Alten-Lorenz 2013-05-29, 08:21
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review21153----------------------------------------------------------- Ship it! Ship It! - Alexander Alten-Lorenz On March 14, 2013, 7:14 a.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9842/> ----------------------------------------------------------- > > (Updated March 14, 2013, 7:14 a.m.) > > > Review request for Flume. > > > Description > ------- > > Ref: https://issues.apache.org/jira/browse/FLUME-1938 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 > > Diff: https://reviews.apache.org/r/9842/diff/> > > Testing > ------- > > Functional test done resulting in full message body being written to file. > > > Thanks, > > Ambud Sharma > >
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-06-03, 21:26
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- (Updated June 3, 2013, 9:26 p.m.) Review request for Flume. Changes ------- Diff with unit test and TCP compliance Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs (updated) ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing ------- Functional test done resulting in full message body being written to file. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-06-03, 21:38
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- (Updated June 3, 2013, 9:38 p.m.) Review request for Flume. Changes ------- Spaces fix Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs (updated) ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing ------- Functional test done resulting in full message body being written to file. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Ambud Sharma 2013-06-03, 21:41
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/----------------------------------------------------------- (Updated June 3, 2013, 9:41 p.m.) Review request for Flume. Description ------- Ref: https://issues.apache.org/jira/browse/FLUME-1938 Diffs (updated) ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 Diff: https://reviews.apache.org/r/9842/diff/Testing ------- Functional test done resulting in full message body being written to file. Thanks, Ambud Sharma
-
Re: Review Request: Flume UDP Source for Windows Events being trimmed at \n characters by SyslogUtils.extractEvent() function
Alexander Alten-Lorenz 2013-06-08, 05:50
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review21613----------------------------------------------------------- Ship it! Thanks for finding and fixing the SyslogTCP issue. Looks good to me. - Alexander Alten-Lorenz On June 3, 2013, 9:41 p.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9842/> ----------------------------------------------------------- > > (Updated June 3, 2013, 9:41 p.m.) > > > Review request for Flume. > > > Description > ------- > > Ref: https://issues.apache.org/jira/browse/FLUME-1938 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java 5a73c88 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java c2a29a1 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 7208464 > > Diff: https://reviews.apache.org/r/9842/diff/> > > Testing > ------- > > Functional test done resulting in full message body being written to file. > > > Thanks, > > Ambud Sharma > >
|
|
