Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 12269: SQOOP-1124: Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings


Copy link to this message
-
Re: Review Request 12269: SQOOP-1124: Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12269/#review22956
-----------------------------------------------------------

Ship it!
The changes looks good to me, please upload the patch to the JIRA, so that I can commit it!

- Jarek Cecho
On July 10, 2013, 5:51 a.m., Masatake Iwasaki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12269/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 5:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1124
>     https://issues.apache.org/jira/browse/SQOOP-1124
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Attached patch includes following changes:
> 1. handling for the case JdbcUrl.getPort returns -1 is added to PGBulkloadExportMapper,
> 2. settings for PGBulkloadManagerManualTest such as database, and username ,tablespace and path of pg_bulkload are made configurable via system property,
> 3. using not Configuration but JobConf in PGBulkloadManagerManualTest to follow changes in DBConfiguration.
>
>
> Diffs
> -----
>
>   build.xml ef657e3
>   src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java 79fb7da
>   src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportMapper.java 333546f
>   src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java 0403614
>
> Diff: https://reviews.apache.org/r/12269/diff/
>
>
> Testing
> -------
>
> passed PGBulkloadManagerManualTest on PostgreSQL 9.2.4 and pg_bulkload 3.1.3.
>
>
> Thanks,
>
> Masatake Iwasaki
>
>