Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-387 : Use TRUNCATE for PostgresqlManager patch


+
Shinichi Yamashita 2012-10-21, 15:08
Copy link to this message
-
Review Request: SQOOP-387 : Use TRUNCATE for PostgreSQLManager patch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4272/
-----------------------------------------------------------

Review request for Sqoop and Bilung Lee.
Summary
-------

I fixed SQOOP-387 patch.

1. I add getDeleteQuery method, which returns DELETE statement in SqlManager by default and returns TRUNCATE statement in PostgreSQLManager.
2. Modify deleteAllRecords method and migrateData method of SqlManager to use getDeleteQuery method.
This addresses bug SQOOP-387.
    https://issues.apache.org/jira/browse/SQOOP-387
Diffs
-----

  http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/manager/PostgresqlManager.java 1298894
  http://svn.apache.org/repos/asf/incubator/sqoop/trunk/src/java/org/apache/sqoop/manager/SqlManager.java 1298894

Diff: https://reviews.apache.org/r/4272/diff
Testing
-------

ant test
I confirmed "TRUNCATE TABLE" query was executed in PostgreSQL.
Thanks,

Shinichi

+
Bilung Lee 2012-03-13, 23:53