Accumulo, mail # dev - Re: Review Request: Add import/export table

Review Request: Add import/export table

keith@... 2012-07-25, 17:06

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/
-----------------------------------------------------------

Review request for accumulo.
Description
-------

A patch to add import and export table to Accumulo
This addresses bug ACCUMULO-456.
   https://issues.apache.org/jira/browse/ACCUMULO-456
Diffs
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1365317
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
  /trunk/core/src/main/thrift/client.thrift 1365317
  /trunk/core/src/main/thrift/master.thrift 1365317
  /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1365317
  /trunk/docs/examples/README.export PRE-CREATION
  /trunk/docs/src/user_manual/chapters/table_configuration.tex 1365317
  /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1365317
  /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1365317
  /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
  /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION

Diff: https://reviews.apache.org/r/6138/diff/
Testing
-------
Thanks,

kturner

Re: Review Request: Add import/export table

keith@... 2012-07-26, 15:37

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9499
-----------------------------------------------------------

/trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
<https://reviews.apache.org/r/6138/#comment20320>

   Needs javadoc

/trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
<https://reviews.apache.org/r/6138/#comment20321>

   Needs java doc

/trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java
<https://reviews.apache.org/r/6138/#comment20322>

   This method should check if the exported table has custom code configured (iterators, contraints, table balancer). If it does, then a log messages should be emitted informing the user that the class files must exist on this system
- kturner
On July 25, 2012, 5:06 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 25, 2012, 5:06 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1365317
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1365317
> /trunk/core/src/main/thrift/master.thrift 1365317
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1365317
> /trunk/docs/examples/README.export PRE-CREATION
> /trunk/docs/src/user_manual/chapters/table_configuration.tex 1365317
> /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1365317
> /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1365317
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6138/diff/

Re: Review Request: Add import/export table

keith@... 2012-07-31, 21:51

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/
-----------------------------------------------------------

(Updated July 31, 2012, 9:51 p.m.)
Review request for accumulo.
Changes
-------

Add patch with java docs, tests, and check for class files on import.
Description
-------

A patch to add import and export table to Accumulo
This addresses bug ACCUMULO-456.
   https://issues.apache.org/jira/browse/ACCUMULO-456
Diffs (updated)
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
  /trunk/core/src/main/thrift/client.thrift 1366092
  /trunk/core/src/main/thrift/master.thrift 1366092
  /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092
  /trunk/docs/examples/README.export PRE-CREATION
  /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092
  /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1366092
  /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1366092
  /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
  /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
  /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java PRE-CREATION
  /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092

Diff: https://reviews.apache.org/r/6138/diff/
Testing
-------
Thanks,

kturner

Re: Review Request: Add import/export table

Josh Elser 2012-08-01, 21:55

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9723
-----------------------------------------------------------

/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java
<https://reviews.apache.org/r/6138/#comment20703>

Swap "<import dir>" for "<export dir>"
- Josh Elser
On July 31, 2012, 9:51 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:51 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1366092
> /trunk/core/src/main/thrift/master.thrift 1366092
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092
> /trunk/docs/examples/README.export PRE-CREATION
> /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java PRE-CREATION
> /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092
>
> Diff: https://reviews.apache.org/r/6138/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kturner
>
>

Re: Review Request: Add import/export table

Josh Elser 2012-08-01, 21:58

> On Aug. 1, 2012, 9:55 p.m., Josh Elser wrote:
> > /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java, line 39
> > <https://reviews.apache.org/r/6138/diff/2/?file=131581#file131581line39>
> >
> > Swap "<import dir>" for "<export dir>"

Ignoring my reversal there, I see how you might have intended that. Perhaps "<exported table dir>" or "<dir to import>" would be more clear?
- Josh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9723
-----------------------------------------------------------
On July 31, 2012, 9:51 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:51 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1366092
> /trunk/core/src/main/thrift/master.thrift 1366092
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092
> /trunk/docs/examples/README.export PRE-CREATION
> /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java PRE-CREATION
> /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092

Re: Review Request: Add import/export table

keith@... 2012-08-02, 14:47

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9754
-----------------------------------------------------------

/trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java
<https://reviews.apache.org/r/6138/#comment20739>

I initially called it "import dir". Then I started thinking: the exported dir is whats being imported. I think I over analyzed the situation. I will go with my first instinct and your first instinct and call it 'import dir' in the API and shell.
- kturner
On July 31, 2012, 9:51 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:51 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1366092
> /trunk/core/src/main/thrift/master.thrift 1366092
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092
> /trunk/docs/examples/README.export PRE-CREATION
> /trunk/docs/src/user_manual/chapters/table_configuration.tex 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1366092
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
> /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java PRE-CREATION
> /trunk/test/system/randomwalk/conf/modules/Shard.xml 1366092

Re: Review Request: Add import/export table

Eric Newton 2012-08-06, 13:08

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9885
-----------------------------------------------------------

/trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java
<https://reviews.apache.org/r/6138/#comment21011>

   Any reason why we don't have a a non-static version of ColumnFQ.fetch? We could simply write:

   METADATA_PREV_ROW_COLUMN.fetch(metaScanner);

/trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java
<https://reviews.apache.org/r/6138/#comment21012>

   Let's make the Master's getConnector method public, so we can avoid calls to HdfsZooInstance.getInstance().

/trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java
<https://reviews.apache.org/r/6138/#comment21013>

   maybe use try/finally to avoid leaking resources when errors occur

/trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java
<https://reviews.apache.org/r/6138/#comment21014>

   if we are going to collect timing information, we should probably trace it, too. Oh, wait... this is a randomwalk test. Nevermind. :-)
- Eric Newton
On July 31, 2012, 9:51 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:51 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1366092
> /trunk/core/src/main/thrift/master.thrift 1366092
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092
> /trunk/docs/examples/README.export PRE-CREATION

Re: Review Request: Add import/export table

keith@... 2012-08-06, 14:21

> On Aug. 6, 2012, 1:08 p.m., Eric Newton wrote:
> > /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java, line 197
> > <https://reviews.apache.org/r/6138/diff/2/?file=131589#file131589line197>
> >
> > Any reason why we don't have a a non-static version of ColumnFQ.fetch? We could simply write:
> >
> > METADATA_PREV_ROW_COLUMN.fetch(metaScanner);

I would prefer to do a change like that as part of another ticket and patch/commit. Making that change would touch a lot of code unrelated to this ticket. Concise patches are nice when reviewing code, merging, and investigating bugs.
> On Aug. 6, 2012, 1:08 p.m., Eric Newton wrote:
> > /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java, line 199
> > <https://reviews.apache.org/r/6138/diff/2/?file=131590#file131590line199>
> >
> > Let's make the Master's getConnector method public, so we can avoid calls to HdfsZooInstance.getInstance().

This would also be a candidate for another ticket and patch. If this were done, it would be best to do it for all FATE operations instead of just this new one.
- kturner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/#review9885
-----------------------------------------------------------
On July 31, 2012, 9:51 p.m., kturner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:51 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch to add import and export table to Accumulo
>
>
> This addresses bug ACCUMULO-456.
> https://issues.apache.org/jira/browse/ACCUMULO-456
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1366092
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
> /trunk/core/src/main/thrift/client.thrift 1366092
> /trunk/core/src/main/thrift/master.thrift 1366092
> /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1366092

Re: Review Request: Add import/export table

Eric Newton 2012-08-06, 16:23

ACCUMULO-717 and ACCUMULO-718.

-Eric

On Mon, Aug 6, 2012 at 10:21 AM, <[EMAIL PROTECTED]> wrote:

>
>
> > On Aug. 6, 2012, 1:08 p.m., Eric Newton wrote:
> > >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java,
> line 197
> > > <
> https://reviews.apache.org/r/6138/diff/2/?file=131589#file131589line197>
> > >
> > > Any reason why we don't have a a non-static version of
> ColumnFQ.fetch? We could simply write:
> > >
> > > METADATA_PREV_ROW_COLUMN.fetch(metaScanner);
>
> I would prefer to do a change like that as part of another ticket and
> patch/commit. Making that change would touch a lot of code unrelated to
> this ticket. Concise patches are nice when reviewing code, merging, and
> investigating bugs.
>
>
> > On Aug. 6, 2012, 1:08 p.m., Eric Newton wrote:
> > >
> /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java,
> line 199
> > > <
> https://reviews.apache.org/r/6138/diff/2/?file=131590#file131590line199>
> > >
> > > Let's make the Master's getConnector method public, so we can
> avoid calls to HdfsZooInstance.getInstance().
>
> This would also be a candidate for another ticket and patch. If this were
> done, it would be best to do it for all FATE operations instead of just
> this new one.
>
>
> - kturner
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6138/#review9885
> -----------------------------------------------------------
>
>
> On July 31, 2012, 9:51 p.m., kturner wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6138/
> > -----------------------------------------------------------
> >
> > (Updated July 31, 2012, 9:51 p.m.)
> >
> >
> > Review request for accumulo.
> >
> >
> > Description
> > -------
> >
> > A patch to add import and export table to Accumulo
> >
> >
> > This addresses bug ACCUMULO-456.
> > https://issues.apache.org/jira/browse/ACCUMULO-456
> >
> >
> > Diffs
> > -----
> >
> > /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java
> 1366092
> > /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java
> 1366092
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java
> PRE-CREATION
> >
> /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java

Re: Review Request: Add import/export table

keith@... 2012-08-06, 18:24

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6138/
-----------------------------------------------------------

(Updated Aug. 6, 2012, 6:24 p.m.)
Review request for accumulo.
Changes
-------

Changes since previous patch
* changed argument name to importDir for importTable API call
* close files and batch writers in finally blocks
Description
-------

A patch to add import and export table to Accumulo
This addresses bug ACCUMULO-456.
   https://issues.apache.org/jira/browse/ACCUMULO-456
Diffs (updated)
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/Constants.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/ClientService.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/conf/Property.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/MasterMonitorInfo.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TableOperation.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/master/thrift/TabletServerStatus.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ActiveScan.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TIteratorSetting.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java 1369905
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExportTableCommand.java PRE-CREATION
  /trunk/core/src/main/java/org/apache/accumulo/core/util/shell/commands/ImportTableCommand.java PRE-CREATION
  /trunk/core/src/main/thrift/client.thrift 1369905
  /trunk/core/src/main/thrift/master.thrift 1369905
  /trunk/core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java 1369905
  /trunk/docs/examples/README.export PRE-CREATION
  /trunk/docs/src/user_manual/chapters/table_configuration.tex 1369905
  /trunk/server/src/main/java/org/apache/accumulo/server/master/Master.java 1369905
  /trunk/server/src/main/java/org/apache/accumulo/server/master/state/tables/TableManager.java 1369905
  /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ExportTable.java PRE-CREATION
  /trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/ImportTable.java PRE-CREATION
  /trunk/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ExportIndex.java PRE-CREATION
  /trunk/test/system/randomwalk/conf/modules/Shard.xml 1369905

Diff: https://reviews.apache.org/r/6138/diff/
Testing
-------
Thanks,

kturner