Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Sqoop2: Move string constants from FormDisplayer to resource file


Copy link to this message
-
Re: Review Request: Sqoop2: Move string constants from FormDisplayer to resource file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/#review17956
-----------------------------------------------------------
Hi Vasanth,
thank you very much for reworking this patch. Would you mind putting the string resource constants into the client's Constant class?

Jarcec

- Jarek Cecho
On March 11, 2013, 12:33 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9669/
> -----------------------------------------------------------
>
> (Updated March 11, 2013, 12:33 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Move string constants from FormDisplayer to resource file
>
>
> This addresses bug SQOOP-887.
>     https://issues.apache.org/jira/browse/SQOOP-887
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 8c133f2
>   client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java abd9643
>   client/src/main/resources/client-resource.properties c3a22bb
>
> Diff: https://reviews.apache.org/r/9669/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>