Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 15499: ACCUMULO-1852 - NativeMapIT on OS X


Copy link to this message
-
Re: Review Request 15499: ACCUMULO-1852 - NativeMapIT on OS X
Michael Berman 2013-11-14, 14:24

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15499/#review28867
-----------------------------------------------------------

Ship it!
This does fix NativeMapIT for me on Mavericks+Java7, although it doesn't address the `make test` issue in nativeMap itself.  Still, seems like an improvement, so, ship it.

- Michael Berman
On Nov. 13, 2013, 10:56 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15499/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 10:56 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1852
>     https://issues.apache.org/jira/browse/ACCUMULO-1852
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Changes (possibly only initial) made to get NativeMapIT running on Mac OS X.
>
>
> Diffs
> -----
>
>   assemble/src/main/assemblies/component.xml 3655a22b6271e1f08c479124605df7088efb2ff6
>   minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java 42882bb82c46a1a4fd407e36a3ee13e954aa2b40
>   server/native/src/main/resources/Makefile 6309e6d44514432da491fd8cf8981524e5014abe
>
> Diff: https://reviews.apache.org/r/15499/diff/
>
>
> Testing
> -------
>
> Ran `mvn verify` to completion, both specifically targeting NativeMapIT and running all tests. Platform is OS X 10.8.5, Java 1.6.0_65. I made the effort to keep the tests working under Java 7 as well, but I have not tried it myself; someone should attempt it (under the test source tree: mvn -Dtest=NativeMapIT -DfailIfNoTests=false clean verify).
>
>
> Thanks,
>
> Bill Havanki
>
>