Flume, mail # dev - Review Request: FLUME-1689: BodyTextSerializer should allow an option not to add a newline to each serialized event

Review Request: FLUME-1689: BodyTextSerializer should allow an option not to add a newline to each serialized event

Mike Percy 2012-11-07, 23:31

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7939/
-----------------------------------------------------------

Review request for Flume.
Description
-------

Small patch to enable either configurable appending of a newline, as done today, or not. Also added docs.
This addresses bug FLUME-1689.
   https://issues.apache.org/jira/browse/FLUME-1689
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/serialization/BodyTextEventSerializer.java dc291cd
  flume-ng-core/src/test/java/org/apache/flume/serialization/TestBodyTextEventSerializer.java e3cb255
  flume-ng-doc/sphinx/FlumeUserGuide.rst e37d0d1

Diff: https://reviews.apache.org/r/7939/diff/
Testing
-------

Added / improved unit tests.
Thanks,

Mike Percy

Re: Review Request: FLUME-1689: BodyTextSerializer should allow an option not to add a newline to each serialized event

Alexander Alten-Lorenz 2012-11-08, 07:32

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7939/#review13239
-----------------------------------------------------------

Ship it!
Good documentation, thank you Mike.

- Alexander Alten-Lorenz
On Nov. 7, 2012, 11:31 p.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7939/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2012, 11:31 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Small patch to enable either configurable appending of a newline, as done today, or not. Also added docs.
>
>
> This addresses bug FLUME-1689.
> https://issues.apache.org/jira/browse/FLUME-1689
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/serialization/BodyTextEventSerializer.java dc291cd
> flume-ng-core/src/test/java/org/apache/flume/serialization/TestBodyTextEventSerializer.java e3cb255
> flume-ng-doc/sphinx/FlumeUserGuide.rst e37d0d1
>
> Diff: https://reviews.apache.org/r/7939/diff/
>
>
> Testing
> -------
>
> Added / improved unit tests.
>
>
> Thanks,
>
> Mike Percy
>
>

Re: Review Request: FLUME-1689: BodyTextSerializer should allow an option not to add a newline to each serialized event

Brock Noland 2012-11-09, 19:20

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7939/#review13298
-----------------------------------------------------------

Ship it!
Ship It!

- Brock Noland
On Nov. 7, 2012, 11:31 p.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7939/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2012, 11:31 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Small patch to enable either configurable appending of a newline, as done today, or not. Also added docs.
>
>
> This addresses bug FLUME-1689.
> https://issues.apache.org/jira/browse/FLUME-1689
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/serialization/BodyTextEventSerializer.java dc291cd
> flume-ng-core/src/test/java/org/apache/flume/serialization/TestBodyTextEventSerializer.java e3cb255
> flume-ng-doc/sphinx/FlumeUserGuide.rst e37d0d1
>
> Diff: https://reviews.apache.org/r/7939/diff/
>
>
> Testing
> -------
>
> Added / improved unit tests.
>
>
> Thanks,
>
> Mike Percy
>
>