Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-540: Microsoft SQL Connector doesn't support custom schemas


Copy link to this message
-
Re: Review Request: SQOOP-540: Microsoft SQL Connector doesn't support custom schemas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7369/#review12071
-----------------------------------------------------------
Looks good. I have one question regarding CONNECTOR_FACTORY as below.

I also found "ant checkstyle" fails with an error. Although the error is not introduced by this patch, can you please address it in this patch too?

-      if((Boolean)isSecurityEnabled.invoke(null)) {
+      if ((Boolean)isSecurityEnabled.invoke(null)) {

Thanks!
src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java
<https://reviews.apache.org/r/7369/#comment25722>

    This was added to make it easier to test the MS connector (http://www.microsoft.com/en-us/download/details.aspx?id=27584). Are you removing this because testing the MS connector is not that useful anymore?
    
    If that's the intention, can you please remove relevant code in build.xml (line 261 - 271) too?
- Cheolsoo Park
On Oct. 1, 2012, 12:19 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7369/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2012, 12:19 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've chosen similar implementation path as was used in PostgreSQL Connector.
>
>
> This addresses bug SQOOP-540.
>     https://issues.apache.org/jira/browse/SQOOP-540
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/manager/SQLServerManager.java 7ce1edd
>   src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java a56b93d
>   src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java PRE-CREATION
>   src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 0f949f4
>
> Diff: https://reviews.apache.org/r/7369/diff/
>
>
> Testing
> -------
>
> I've test my changes (both import and export) against Microsoft SQL Server Express 2012.
>
>
> Thanks,
>
> Jarek Cecho
>
>