Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Re: Review Request: FLUME-1830: Flume User Guide missing some props for SpoolDirectorySource


+
Alexander Alten-Lorenz 2013-01-24, 10:48
Copy link to this message
-
Re: Review Request: FLUME-1830: Flume User Guide missing some props for SpoolDirectorySource
Juhani Connolly 2013-01-25, 02:14

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8941/#review15671
-----------------------------------------------------------
Thanks for the patch.

Since the deserializer is configurable, and not all deserializers will use the same properties, is documenting them appropriate?

- Juhani Connolly
On Jan. 24, 2013, 10:48 a.m., Alexander Alten-Lorenz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8941/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 10:48 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Flume User Guide is missing these props (along with a description of what they do) that are present in the SpoolDirectorySource and LineDeserializer source file
>
>
> This addresses bug FLUME-1830.
>     https://issues.apache.org/jira/browse/FLUME-1830
>
>
> Diffs
> -----
>
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b
>
> Diff: https://reviews.apache.org/r/8941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Alten-Lorenz
>
>

+
Juhani Connolly 2013-01-25, 02:31
+
Mike Percy 2013-01-25, 10:59
+
Alexander Alten-Lorenz 2013-01-25, 11:12