Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-459 Remove redundant steps in compatibility tests: verifyReadback() method


Copy link to this message
-
Re: Review Request: SQOOP-459 Remove redundant steps in compatibility tests: verifyReadback() method
Bilung Lee 2012-03-09, 20:40

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4266/#review5800
-----------------------------------------------------------

Ship it!
Thanks for the patch!

- Bilung
On 2012-03-09 19:38:14, Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4266/
> -----------------------------------------------------------
>
> (Updated 2012-03-09 19:38:14)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Summary
> -------
>
> Several tests including ManagerCompatTest do the following:
>
> 1) Tests insert data
> 2) Compare output from the db against inserted values
> 3) Run Sqoop import jobs
> 4) Compare output read from seq files against inserted values
>
> Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.
>
> Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.
>
>
> This addresses bug SQOOP-459.
>     https://issues.apache.org/jira/browse/SQOOP-459
>
>
> Diffs
> -----
>
>   ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
>   ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
>   ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
>   ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
>   ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
>   ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661
>
> Diff: https://reviews.apache.org/r/4266/diff
>
>
> Testing
> -------
>
> Ran
> ant test
> ant test -Dthirdparty
> ant checkstyle
>
>
> Thanks,
>
> Cheolsoo
>
>