Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 14240: SQOOP-1032: Add the --bulk-load-dir option to support the HBase doBulkLoad function


Copy link to this message
-
Re: Review Request 14240: SQOOP-1032: Add the --bulk-load-dir option to support the HBase doBulkLoad function
Alexandre Normand 2013-10-02, 21:21

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14240/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 9:21 p.m.)
Review request for Sqoop, Jarek Cecho, Jean-Marc Spaggiari, and vasanthkumar.
Changes
-------

I refactored some of the duplicate code. This helps to both minimize the amount of untested code and maintenance of this code. About the testing of the bulk load functionality, I think I mentioned it on the earlier review but it's not possible to test in non distributed mode. This is the kind of error that we would get:

Caused by: java.io.FileNotFoundException: File _partition.lst does not exist.

Any specific things that you would like to be tested that can be (anything that would execute configureIncrementalLoad or doBulkLoad would fail)?
Repository: sqoop-trunk
Description
-------

This is the patch to address some of the comments on Zhancheng Deng's review request (https://reviews.apache.org/r/13052/) which was basically the change to add the --bulk-load-dir option to support the HBase doBulkLoad function.
Diffs (updated)
-----

  src/java/org/apache/sqoop/SqoopOptions.java 01805f9
  src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 9ceb5bd
  src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 5ccf311
  src/java/org/apache/sqoop/manager/SqlManager.java 2a4992d
  src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java PRE-CREATION
  src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java PRE-CREATION
  src/java/org/apache/sqoop/mapreduce/ImportJobBase.java ab7f21e
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0eca991

Diff: https://reviews.apache.org/r/14240/diff/
Testing
-------
Thanks,

Alexandre Normand