Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request: For Jira HIVE-4398


Copy link to this message
-
Re: Review Request: For Jira HIVE-4398

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10757/#review19640
-----------------------------------------------------------

branches/branch-0.11/service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/10757/#comment40555>

    Please change the name to 'opHandleSet' or 'operationSet'. Thanks.

branches/branch-0.11/service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/10757/#comment40553>

    Please use a for-each loop:
    http://docs.oracle.com/javase/1.5.0/docs/guide/language/foreach.html
    

branches/branch-0.11/service/src/test/org/apache/hive/service/cli/operation/TestCloseOperations.java
<https://reviews.apache.org/r/10757/#comment40550>

    Formatting: please fix the indentation in this file.
- Carl Steinbach
On April 24, 2013, 5:23 p.m., Ashish Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10757/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 5:23 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
>
>
> Description
> -------
>
>
> Addressing latest comments from Thejas. This keeps OperationManager.java unchanged.
>
>
> This addresses bug HIVE-4398.
>     https://issues.apache.org/jira/browse/HIVE-4398
>
>
> Diffs
> -----
>
>   branches/branch-0.11/service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 1471543
>   branches/branch-0.11/service/src/test/org/apache/hive/service/cli/operation/TestCloseOperations.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Vaidya
>
>