Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Re: Review Request 13760: DRILL-182 : abs() function implementation


Copy link to this message
-
Re: Review Request 13760: DRILL-182 : abs() function implementation
Jacques Nadeau 2013-09-02, 00:12

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13760/#review25817
-----------------------------------------------------------

sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java
<https://reviews.apache.org/r/13760/#comment50364>

    You should just create your own data if you're not happy with the mock scan data.  A bunch of stuff rely on that being a consistent set of data.
- Jacques Nadeau
On Aug. 29, 2013, 2:47 a.m., Tanujit Ghosh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13760/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2013, 2:47 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Implementation of the abs() function within DRILL.
>
>
> Diffs
> -----
>
>   sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java 311e715
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 78630ba
>   sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java ce5dccd
>   sandbox/prototype/exec/java-exec/src/test/resources/functions/testMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13760/diff/
>
>
> Testing
> -------
>
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
>
>
> Thanks,
>
> Tanujit Ghosh
>
>