Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
HDFS, mail # dev - VOTE: HDFS-347 merge


+
Colin McCabe 2013-02-17, 21:48
+
Andrew Purtell 2013-02-18, 02:35
+
Stack 2013-02-18, 01:49
+
Tsz Wo Sze 2013-02-18, 22:03
+
Todd Lipcon 2013-02-20, 00:11
+
Patrick Angeles 2013-02-20, 18:08
+
Tsz Wo Sze 2013-02-20, 19:56
+
Tsz Wo Sze 2013-02-20, 23:01
+
Todd Lipcon 2013-02-20, 23:06
+
Todd Lipcon 2013-02-20, 23:06
+
Tsz Wo Sze 2013-02-20, 23:08
+
Todd Lipcon 2013-02-20, 23:13
+
Suresh Srinivas 2013-02-20, 23:31
+
Todd Lipcon 2013-02-20, 23:40
+
Suresh Srinivas 2013-02-21, 00:04
+
Todd Lipcon 2013-02-21, 00:12
Copy link to this message
-
Re: VOTE: HDFS-347 merge
Suresh Srinivas 2013-02-21, 00:28
>
> The patches even going back as far as last September have all removed
> the old code path. I sort of assumed that, if you are taking time to
> review the patches, you would have noticed this... additionally,
> Colin's comments on the JIRA said as much... eg:
>

Todd, we have different ways of reviewing and tracking work that
happens in a branch. In fact if you look at snapshots branch, a
functionality was coded and optimized/rewritten multiple times.
My approach is to review final consolidated patch. That is the reason
why I have been keeping HADOOP-8562 updated, so reviewers
can see the latest patch.
>  "The old RPC is now deprecated and will always throw an
> AccessControlException, so that older clients will fall back to remote
> reads."
> "BlockReaderLocal: simpler implementation that uses raw FileChannel
> objects. We don't need to cache anything, or make RPCs to the
> DataNode."
Sorry this is not explicit. HDFS-347 has been around for a long time.
Stating "HDFS-2246 short circuit mechanism will be removed from
the client" is what I call explicitly stating it.

To summarize I want to retain old short circuit and will spend time
maintaining it for the following reasons:
- It is a functionality that is already available and it supports all
  all the platforms.
- I know great deal of testing has gone into HDFS-347. But if any
  issue is discovered, it is good to have old functionality as a fallback
  option.

Please consider these thoughts and do not take it as impeding the work.
I am actually trying to help here.

Regards,
Suresh
--
http://hortonworks.com/download/
+
Chris Douglas 2013-02-21, 00:29
+
Aaron T. Myers 2013-02-21, 01:12
+
Suresh Srinivas 2013-02-21, 15:40
+
Andrew Purtell 2013-02-21, 01:32
+
Chris Douglas 2013-02-21, 21:24
+
Tsz Wo Sze 2013-02-21, 22:15
+
Eli Collins 2013-02-22, 21:55
+
Tsz Wo Sze 2013-02-23, 02:32
+
Aaron T. Myers 2013-02-23, 02:40
+
Tsz Wo Sze 2013-02-24, 00:23
+
Eli Collins 2013-02-25, 18:24
+
Tsz Wo Sze 2013-02-25, 20:50
+
Eli Collins 2013-02-25, 21:16
+
Chris Douglas 2013-02-25, 21:50
+
Suresh Srinivas 2013-02-26, 00:09
+
Eli Collins 2013-02-26, 00:39
+
Suresh Srinivas 2013-02-26, 17:33
+
Eli Collins 2013-02-26, 19:24
+
Suresh Srinivas 2013-02-26, 19:35
+
Eli Collins 2013-02-26, 21:51
+
Chris Douglas 2013-02-27, 00:52
+
Suresh Srinivas 2013-02-27, 01:09
+
Colin McCabe 2013-03-05, 20:24
+
Suresh Srinivas 2013-03-05, 21:09
+
Tsz Wo Sze 2013-03-05, 23:08
+
sanjay Radia 2013-02-27, 19:45
+
Eli Collins 2013-02-27, 20:06
+
Colin McCabe 2013-02-27, 23:28
+
Eli Collins 2013-02-27, 23:42
+
Chris Douglas 2013-02-27, 23:29
+
Eli Collins 2013-02-25, 22:01
+
Colin McCabe 2013-02-25, 18:31
+
Colin McCabe 2013-02-22, 19:13
+
sanjay Radia 2013-02-27, 01:36
+
Suresh Srinivas 2013-02-21, 00:47
+
Todd Lipcon 2013-02-20, 20:16
+
Suresh Srinivas 2013-02-20, 22:49
+
Todd Lipcon 2013-02-20, 23:01
+
Suresh Srinivas 2013-02-20, 23:19
+
Tsz Wo Sze 2013-02-20, 21:48
+
Todd Lipcon 2013-02-20, 22:27
+
Bikas Saha 2013-02-26, 21:47
+
Todd Lipcon 2013-02-26, 22:07
+
Colin McCabe 2013-04-01, 23:32