Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 15151: Better error reporting by async threads in HiveServer2


Copy link to this message
-
Re: Review Request 15151: Better error reporting by async threads in HiveServer2


> On Nov. 15, 2013, 9:02 a.m., Carl Steinbach wrote:
> > service/if/TCLIService.thrift, line 491
> > <https://reviews.apache.org/r/15151/diff/5/?file=383817#file383817line491>
> >
> >     Please bump this to V5. Also, does the V5 client now make any assumptions about the server being V5 too? Do we need to add any conditional version detection logic to the JDBC driver or CLIServiceClient?
> >    
> >     Do we currently log the client version on the server side and vice versa? If not it would probably be good to add this.

Ya, we do check the version match in JDBC but not in ThriftCLIServiceClient. My bad, I didn't run the JDBC test after the patch that bumped the version to V5. Added the client version logging on the server side.
- Vaibhav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15151/#review28949
-----------------------------------------------------------
On Nov. 13, 2013, 9:54 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15151/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 9:54 p.m.)
>
>
> Review request for hive, Carl Steinbach, Prasad Mujumdar, and Thejas Nair.
>
>
> Bugs: HIVE-5230
>     https://issues.apache.org/jira/browse/HIVE-5230
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> [HIVE-4617|https://issues.apache.org/jira/browse/HIVE-4617] provides support for async execution in HS2. When a background thread gets an error, currently the client can only poll for the operation state and also the error with its stacktrace is logged. However, it will be useful to provide a richer error response like thrift API does with TStatus (which is constructed while building a Thrift response object).
>
>
> Diffs
> -----
>
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java fce19bf
>   service/if/TCLIService.thrift 1f49445
>   service/src/java/org/apache/hive/service/cli/CLIService.java 8c85386
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 14ef54f
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9dca874
>   service/src/java/org/apache/hive/service/cli/HiveSQLException.java 74e8b94
>   service/src/java/org/apache/hive/service/cli/ICLIService.java f647ce6
>   service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1
>   service/src/java/org/apache/hive/service/cli/OperationStatus.java PRE-CREATION
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java bcdb67f
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 9df110e
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 9bb2a0f
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a
>   service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d
>
> Diff: https://reviews.apache.org/r/15151/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>