|
|
-
Refactoring checkAndPut and checkAndDelete to use doMiniBatchMutation
Ramkrishna.S.Vasudevan 2012-08-30, 09:53
Hi
Currently the checkAndPut and checkAndDelete api internally calls the internalPut and internalDelete. May be we can just call doMiniBatchMutation only. This will help in future like if we have some hooks and the CP handles certain cases in the doMiniBatchMutation the same can be done while doing a put thro checkAndPut or while doing a delete thro checkAndDelete.
If we are fine with this I can raise a JIRA and submit a patch which should be a simple one.
Regards
Ram
-
Re: Refactoring checkAndPut and checkAndDelete to use doMiniBatchMutation
yuzhihong@... 2012-08-30, 11:31
Please go ahead.
On Aug 30, 2012, at 2:53 AM, "Ramkrishna.S.Vasudevan" <[EMAIL PROTECTED]> wrote:
> Hi > > > > Currently the checkAndPut and checkAndDelete api internally calls the > internalPut and internalDelete. May be we can just call doMiniBatchMutation > only. This will help in future like if we have some hooks and the CP > handles certain cases in the doMiniBatchMutation the same can be done while > doing a put thro checkAndPut or while doing a delete thro checkAndDelete. > > > > If we are fine with this I can raise a JIRA and submit a patch which should > be a simple one. > > > > Regards > > Ram >
-
Re: Refactoring checkAndPut and checkAndDelete to use doMiniBatchMutation
Jonathan Hsieh 2012-08-30, 12:52
Ram,
+1
It would be great if the refactor made adding a "checkAndMututate" method trivial to add. This method would do an atomic check and set that and if successful allowed for atomic deletions and puts on the same row. (current api only allow checkAndDelete, checkAndPut, and batchMutate).
Jon.
On Thu, Aug 30, 2012 at 2:53 AM, Ramkrishna.S.Vasudevan < [EMAIL PROTECTED]> wrote:
> Hi > > > > Currently the checkAndPut and checkAndDelete api internally calls the > internalPut and internalDelete. May be we can just call > doMiniBatchMutation > only. This will help in future like if we have some hooks and the CP > handles certain cases in the doMiniBatchMutation the same can be done while > doing a put thro checkAndPut or while doing a delete thro checkAndDelete. > > > > If we are fine with this I can raise a JIRA and submit a patch which should > be a simple one. > > > > Regards > > Ram > > -- // Jonathan Hsieh (shay) // Software Engineer, Cloudera // [EMAIL PROTECTED]
-
Re: Refactoring checkAndPut and checkAndDelete to use doMiniBatchMutation
Andrew Purtell 2012-08-30, 13:31
+1 Jon's suggestion.
On Thu, Aug 30, 2012 at 3:52 PM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote:
> Ram, > > +1 > > It would be great if the refactor made adding a "checkAndMututate" method > trivial to add. This method would do an atomic check and set that and if > successful allowed for atomic deletions and puts on the same row. (current > api only allow checkAndDelete, checkAndPut, and batchMutate). > > Jon. > > On Thu, Aug 30, 2012 at 2:53 AM, Ramkrishna.S.Vasudevan < > [EMAIL PROTECTED]> wrote: > > > Hi > > > > > > > > Currently the checkAndPut and checkAndDelete api internally calls the > > internalPut and internalDelete. May be we can just call > > doMiniBatchMutation > > only. This will help in future like if we have some hooks and the CP > > handles certain cases in the doMiniBatchMutation the same can be done > while > > doing a put thro checkAndPut or while doing a delete thro checkAndDelete. > > > > > > > > If we are fine with this I can raise a JIRA and submit a patch which > should > > be a simple one. > > > > > > > > Regards > > > > Ram > > > > > > > -- > // Jonathan Hsieh (shay) > // Software Engineer, Cloudera > // [EMAIL PROTECTED] >
-- Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
|
|
All projects made searchable here are trademarks of the Apache Software Foundation.
Service operated by
Sematext