Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig >> mail # dev >> Uploading patches for review

Rohini Palaniswamy 2013-06-06, 01:21
Jarek Jarcec Cecho 2013-06-06, 01:50
Cheolsoo Park 2013-06-06, 06:53
Julien Le Dem 2013-06-06, 09:02
Copy link to this message
Re: Uploading patches for review
I think it's fine for a reviewer to ask for a particular patch to be put in review board.  I think it would also be fine to put in our HowToContribute doc that for larger patches putting it in review board may help get it reviewed more quickly.  I'm not in favor of requiring it, as some reviewers don't use review board.


On Jun 6, 2013, at 2:21 AM, Rohini Palaniswamy wrote:

> Hi,
>    Reviewing uploaded patches for few lines of change is easy. But when
> the change is more it is hard to read, review is more time consuming and at
> times you have to switch between the patch and eclipse to get more context.
> Without the surrounding code it is also easy to miss things on review. Can
> we make it a practice and decide on putting up the patches in review board
> for review if it is slightly bigger? Commenting on the patch is also a
> breeze in the review board.
> Thoughts ???
> Regards,
> Rohini