Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests to repo"


Copy link to this message
-
Re: Review Request: Review request for SQOOP-1033 "CombineFileInputFormat does not work with paths not on default FS like ASV"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10988/#review20319
-----------------------------------------------------------
Thanks for the patch.  You have the testing done section empty.  Can you please update what tests were done.  Is it possible to add a test (Integration Test at least)
src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java
<https://reviews.apache.org/r/10988/#comment41840>

    Can you please add a comment explaining that this is done to preserve scheme and authority.   Is there a test that tests the export to ASV as part of SqlServer integration tests?
- Venkat Ranganathan
On May 8, 2013, 12:38 a.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10988/
> -----------------------------------------------------------
>
> (Updated May 8, 2013, 12:38 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> CombineFileInputFormat does not work with ASV. This appeared as an issue in Sqoop which failed to export files in ASV. CombineFileInputFormat strips out the scheme and authority components of the path, after which point the path is assumed to be on the default file system.
>  Sqoop has it own copy of CombineFileInputFormat, but updated the ones in core as well for consistency.
>
> There are currently already solved Jiras for the same issue:
> https://issues.apache.org/jira/browse/MAPREDUCE-2704
> https://issues.apache.org/jira/browse/MAPREDUCE-1806
>
>
> This addresses bug SQOOP-1033.
>     https://issues.apache.org/jira/browse/SQOOP-1033
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java 7d2be38
>
> Diff: https://reviews.apache.org/r/10988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Shuaishuai Nie
>
>