Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-630: Check if connection/job is in use before deleting as deleting used entity might result in FK violations
Bilung Lee
2012-10-17, 18:34
Copy link to this message
-
Review Request: SQOOP-630: Check if connection/job is in use before deleting as deleting used entity might result in FK violations
Jarek Cecho 2012-10-17, 00:21

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7625/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've implemented such check both for connection and job objects, even thought that checking if job is in use is NOP at the moment (will be improved once submission engine will be in place).
This addresses bug SQOOP-630.
    https://issues.apache.org/jira/browse/SQOOP-630
Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java e76a0ccff37e0599130279ffbb785f56c540a95f
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ff10beefbc69e1dda15cade916ebe683e7fb8991
  core/src/main/java/org/apache/sqoop/repository/RepositoryError.java ca0c5a15e2e3565563ff874dddfe57660e902379
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java 00bc926c24cd6b54d731f46e15da89f9e07cd5f0
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c72a571ee279b36e3b068414d119c347316f1aeb
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java a895cfe327d4f8bd3671c298efdd2f1a6fc1d96f

Diff: https://reviews.apache.org/r/7625/diff/
Testing
-------

No new unit tests included at the moment, manually verified.
Thanks,

Jarek Cecho