Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1713 Netcat source to not return "OK"


+
Rahul Ravindran 2012-11-26, 02:23
+
Rahul Ravindran 2012-11-26, 02:24
+
Mike Percy 2012-11-28, 02:54
Copy link to this message
-
Re: Review Request: FLUME-1713 Netcat source to not return "OK"


> On Nov. 28, 2012, 2:54 a.m., Mike Percy wrote:
> > Looks good!
> >
> > Please make the following changes and then attach the patch to the JIRA:
> > * Rename ackEveryEvent to ack-every-event to remain consistent with the existing elements. Even though we have agreed to make all new properties camel caps, in the case of existing components we should remain consistent with the existing stuff
> > * Please document this new parameter in the user guide @ flume-ng-doc/sphinx/FlumeUserGuide.rst

Thanks Mike!

I am assuming the rename (of ackEveryEvent to act-every-event) is only for the constant which is used by users to set the flag in the config(not in the variable names in code). So, new parameter in the document in FlumeUserGuide.rst would be ack-every-event. Could you confirm?
- Rahul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8220/#review13797
-----------------------------------------------------------
On Nov. 26, 2012, 2:24 a.m., Rahul Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8220/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2012, 2:24 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> FLUME-1713 Netcat source should allow for *not* returning OK upon receipt of each message; Added a config boolean parameter for this source ackEveryEvent(default value:false). Add parameterized test to existing Netcat unit test
>
>
> This addresses bug FLUME-1713.
>     https://issues.apache.org/jira/browse/FLUME-1713
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 37c09fe
>   flume-ng-core/src/main/java/org/apache/flume/source/NetcatSourceConfigurationConstants.java 1d8b5e4
>   flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java 3c17d3d
>
> Diff: https://reviews.apache.org/r/8220/diff/
>
>
> Testing
> -------
>
> Unit test added
>
>
> Thanks,
>
> Rahul Ravindran
>
>

+
Mike Percy 2012-11-28, 08:23
+
Rahul Ravindran 2012-11-28, 21:02
+
Mike Percy 2012-11-29, 07:56