Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-864 Sqoop2: Introduce ETL context objects


+
Jarek Cecho 2013-02-05, 19:47
+
Cheolsoo Park 2013-02-06, 21:47
+
Jarek Cecho 2013-02-08, 21:29
Copy link to this message
-
Re: Review Request: SQOOP-864 Sqoop2: Introduce ETL context objects
Cheolsoo Park 2013-02-10, 20:38

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9311/#review16400
-----------------------------------------------------------
Jarcec, I think you missed one line. Do you mind fixing it?
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java
<https://reviews.apache.org/r/9311/#comment34887>

    I guess you omit to change this?
- Cheolsoo Park
On Feb. 8, 2013, 9:29 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9311/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2013, 9:29 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> This patch seems to be quite enormous, but the logic is fairly simple. I've created family of Context classes - one parent ActorContext and than for each ETL separate child. My reasoning is that each ETL class needs different set of arguments and thus should have it's own Context class. Then I've went and fix all implementations of the ETL classes to conform with the changes.
>
> Each context class is wrapping all parameters in a generic and extensible way. The only parameters that are not part of the Context objects are configuration objects. I wanted to move them into Context classes as well, but that did not work well with the generics, so I kept them separate.
>
>
> This addresses bug SQOOP-864.
>     https://issues.apache.org/jira/browse/SQOOP-864
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/sqoop/etl/io/DataReader.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/etl/io/DataWriter.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/job/etl/ActorContext.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/job/etl/DestroyerContext.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/job/etl/InitializerContext.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/job/etl/PartitionerContext.java PRE-CREATION
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java 2d53bdd0715de86d92ef5286855c8805301caadd
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 06fbc519ab46ea01087e93398292a749b70630e2
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java 5f8e129d43f208a434527edfb771daf67bdf98af
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java f7043ea2bd53409514ac7eb5197f65a076f683b9
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 9db332865f1fcd7e21c48d3fad0c38d2a9f7fb8d
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java a509e2b6dc1b936f9988865cbe44610d77674ee6
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java b5dbc6168093f277de557051fee0afc6c2386c6c
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java c876780d076add6f6644bd2ab7ecb403676328c0
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java 5892cbbe03bd771f8f92cb21a722e4f6607e8107
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java 0be713e81de7ef522b55b1e8d63483cbb9db318e
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java f3c1d90efacb3ba5790e9b216cddb7a7e7bae65c
+
Jarek Cecho 2013-02-10, 20:47
+
Cheolsoo Park 2013-02-10, 20:52