Mahadev Konar <mahadev@...> writes:
>   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>  addressed in this release. This includes the critical bugfix ZOOKEEPER-1550
>  which address the client connection issue.

I ran the kazoo Python client library tests against this.

All tests pass with JDK 7, though they also did for 3.4.4.

So no complains here :)

Hanno

+1

I tested using zkServer.sh to start the server and zkCli.sh to run
some queries. The issue reported in 3.4.4 seems to be gone now.

Thanks Mahadev!
--Michi

On Tue, Oct 2, 2012 at 8:20 AM, Hanno Schlichting <[EMAIL PROTECTED]> wrote:
> Mahadev Konar <mahadev@...> writes:
>>   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>>  addressed in this release. This includes the critical bugfix ZOOKEEPER-1550
>>  which address the client connection issue.
>
> I ran the kazoo Python client library tests against this.
>
> All tests pass with JDK 7, though they also did for 3.4.4.
>
> So no complains here :)
>
> Hanno
>

I'm +1

The HBase + zk3.4.4 + jdk7 combination was badly broke w/ hundreds of
HBase tests failing retrying connectionless up to three times over
many seconds and never succeeding.  Putting in place this RC, all
seems to work nicely again.  HBase passes its 1200 or so unit tests of
which a good portion do various contortions up against zk.

Verified the md5.  Verifying the signature I got this:

stack@sv4r11s38:/export1/stack$ gpg --verify
zookeeper-3.4.5.tar.gz.asc zookeeper-3.4.5.tar.gz
gpg: Signature made Sun 30 Sep 2012 06:01:37 PM UTC using RSA key ID 8EE2F25C
gpg: Good signature from "Mahadev Konar (CODE SIGNING KEY) <[EMAIL PROTECTED]>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: B6B3 F7ED A5BA 7D1E 827D  E518 0DFF 492D 8EE2 F25C

St.Ack

+1, sig/xsum are correct, ran rat an that looked good. All the unit
tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
1/3/5/13 server clusters using openjdk7, everything seems to be
working.

Patrick

On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Hi all,
>
>   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>  addressed in this release. This includes the critical bugfix ZOOKEEPER-1550
>  which address the client connection issue.
>
>  *** Please download, test and VOTE before the
>  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>
> Note that I am extending the vote period for a little longer so that
> folks get time to test this out.
>
>  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
>
>  Should we release this?
>
>  thanks
>  mahadev

Not sure if it's a blocker or some intermittent test issue, but I just
filed this. Jenkins sasl test failure on jdk7:
https://issues.apache.org/jira/browse/ZOOKEEPER-1557

Patrick

On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> +1, sig/xsum are correct, ran rat an that looked good. All the unit
> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
> 1/3/5/13 server clusters using openjdk7, everything seems to be
> working.
>
> Patrick
>
> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Hi all,
>>
>>   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>>  addressed in this release. This includes the critical bugfix ZOOKEEPER-1550
>>  which address the client connection issue.
>>
>>  *** Please download, test and VOTE before the
>>  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>>
>> Note that I am extending the vote period for a little longer so that
>> folks get time to test this out.
>>
>>  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
>>
>>  Should we release this?
>>
>>  thanks
>>  mahadev

Should ZOOKEEPER-1557 be given some time so that we track down root cause ?

Thanks

On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:

> +1, sig/xsum are correct, ran rat an that looked good. All the unit
> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
> 1/3/5/13 server clusters using openjdk7, everything seems to be
> working.
>
> Patrick
>
> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <[EMAIL PROTECTED]>
> wrote:
> > Hi all,
> >
> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
> >  addressed in this release. This includes the critical bugfix
> ZOOKEEPER-1550
> >  which address the client connection issue.
> >
> >  *** Please download, test and VOTE before the
> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
> >
> > Note that I am extending the vote period for a little longer so that
> > folks get time to test this out.
> >
> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
> >
> >  Should we release this?
> >
> >  thanks
> >  mahadev
>

Good point Ted.
Eugene,
 Would you be able to take a quick look and point out the threat level? :)

I have kicked off new build to see if its reproducible or not.

thanks
mahadev

On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> Should ZOOKEEPER-1557 be given some time so that we track down root cause ?
>
> Thanks
>
> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>
>> +1, sig/xsum are correct, ran rat an that looked good. All the unit
>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
>> 1/3/5/13 server clusters using openjdk7, everything seems to be
>> working.
>>
>> Patrick
>>
>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <[EMAIL PROTECTED]>
>> wrote:
>> > Hi all,
>> >
>> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>> >  addressed in this release. This includes the critical bugfix
>> ZOOKEEPER-1550
>> >  which address the client connection issue.
>> >
>> >  *** Please download, test and VOTE before the
>> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>> >
>> > Note that I am extending the vote period for a little longer so that
>> > folks get time to test this out.
>> >
>> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
>> >
>> >  Should we release this?
>> >
>> >  thanks
>> >  mahadev
>>

I noticed that the following build is using jdk 1.6:
https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34

Since a lot of people would be using 3.4.5 on top of jdk 1.7, should we
create a build against jdk 1.7 ?

My two cents.

On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]>wrote:

> Good point Ted.
> Eugene,
>  Would you be able to take a quick look and point out the threat level? :)
>
> I have kicked off new build to see if its reproducible or not.
>
> thanks
> mahadev
>
> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> > Should ZOOKEEPER-1557 be given some time so that we track down root
> cause ?
> >
> > Thanks
> >
> > On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> >
> >> +1, sig/xsum are correct, ran rat an that looked good. All the unit
> >> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
> >> 1/3/5/13 server clusters using openjdk7, everything seems to be
> >> working.
> >>
> >> Patrick
> >>
> >> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <
> [EMAIL PROTECTED]>
> >> wrote:
> >> > Hi all,
> >> >
> >> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
> >> >  addressed in this release. This includes the critical bugfix
> >> ZOOKEEPER-1550
> >> >  which address the client connection issue.
> >> >
> >> >  *** Please download, test and VOTE before the
> >> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
> >> >
> >> > Note that I am extending the vote period for a little longer so that
> >> > folks get time to test this out.
> >> >
> >> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
> >> >
> >> >  Should we release this?
> >> >
> >> >  thanks
> >> >  mahadev
> >>
>

Seems reasonable. I just got builds@ to add openjdk6/7 support to
jenkins, I plan to add jobs for those as well.

Patrick

On Thu, Oct 4, 2012 at 5:04 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> I noticed that the following build is using jdk 1.6:
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34
>
> Since a lot of people would be using 3.4.5 on top of jdk 1.7, should we
> create a build against jdk 1.7 ?
>
> My two cents.
>
> On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]>wrote:
>
>> Good point Ted.
>> Eugene,
>>  Would you be able to take a quick look and point out the threat level? :)
>>
>> I have kicked off new build to see if its reproducible or not.
>>
>> thanks
>> mahadev
>>
>> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> > Should ZOOKEEPER-1557 be given some time so that we track down root
>> cause ?
>> >
>> > Thanks
>> >
>> > On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>> >
>> >> +1, sig/xsum are correct, ran rat an that looked good. All the unit
>> >> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
>> >> 1/3/5/13 server clusters using openjdk7, everything seems to be
>> >> working.
>> >>
>> >> Patrick
>> >>
>> >> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <
>> [EMAIL PROTECTED]>
>> >> wrote:
>> >> > Hi all,
>> >> >
>> >> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>> >> >  addressed in this release. This includes the critical bugfix
>> >> ZOOKEEPER-1550
>> >> >  which address the client connection issue.
>> >> >
>> >> >  *** Please download, test and VOTE before the
>> >> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>> >> >
>> >> > Note that I am extending the vote period for a little longer so that
>> >> > folks get time to test this out.
>> >> >
>> >> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
>> >> >
>> >> >  Should we release this?
>> >> >
>> >> >  thanks
>> >> >  mahadev
>> >>
>>

Doesn't look good, failed a second time:

https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/

java.util.concurrent.TimeoutException: Did not connect
at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
at org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
Patrick

On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Good point Ted.
> Eugene,
>  Would you be able to take a quick look and point out the threat level? :)
>
> I have kicked off new build to see if its reproducible or not.
>
> thanks
> mahadev
>
> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> Should ZOOKEEPER-1557 be given some time so that we track down root cause ?
>>
>> Thanks
>>
>> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>
>>> +1, sig/xsum are correct, ran rat an that looked good. All the unit
>>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
>>> 1/3/5/13 server clusters using openjdk7, everything seems to be
>>> working.
>>>
>>> Patrick
>>>
>>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <[EMAIL PROTECTED]>
>>> wrote:
>>> > Hi all,
>>> >
>>> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>>> >  addressed in this release. This includes the critical bugfix
>>> ZOOKEEPER-1550
>>> >  which address the client connection issue.
>>> >
>>> >  *** Please download, test and VOTE before the
>>> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>>> >
>>> > Note that I am extending the vote period for a little longer so that
>>> > folks get time to test this out.
>>> >
>>> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
>>> >
>>> >  Should we release this?
>>> >
>>> >  thanks
>>> >  mahadev
>>>

fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
jenkins and they are looking good so far:

https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/

Patrick

On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> Doesn't look good, failed a second time:
>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
>
> java.util.concurrent.TimeoutException: Did not connect
>         at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
>         at org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
>
>
> Patrick
>
> On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> Good point Ted.
>> Eugene,
>>  Would you be able to take a quick look and point out the threat level? :)
>>
>> I have kicked off new build to see if its reproducible or not.
>>
>> thanks
>> mahadev
>>
>> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> Should ZOOKEEPER-1557 be given some time so that we track down root cause ?
>>>
>>> Thanks
>>>
>>> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>
>>>> +1, sig/xsum are correct, ran rat an that looked good. All the unit
>>>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
>>>> 1/3/5/13 server clusters using openjdk7, everything seems to be
>>>> working.
>>>>
>>>> Patrick
>>>>
>>>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <[EMAIL PROTECTED]>
>>>> wrote:
>>>> > Hi all,
>>>> >
>>>> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>>>> >  addressed in this release. This includes the critical bugfix
>>>> ZOOKEEPER-1550
>>>> >  which address the client connection issue.
>>>> >
>>>> >  *** Please download, test and VOTE before the
>>>> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>>>> >
>>>> > Note that I am extending the vote period for a little longer so that
>>>> > folks get time to test this out.
>>>> >
>>>> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
>>>> >
>>>> >  Should we release this?
>>>> >
>>>> >  thanks
>>>> >  mahadev
>>>>

Some tests failed in build 8 due to (See
https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/):

java.lang.RuntimeException: java.net.BindException: Address already in use
at org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
at org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
Caused by: java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:344)
at sun.nio.ch.Net.bind(Net.java:336)
at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
at org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
at org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
at org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)

On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:

> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
> jenkins and they are looking good so far:
>
>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/
>
> Patrick
>
> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> > Doesn't look good, failed a second time:
> >
> >
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
> >
> > java.util.concurrent.TimeoutException: Did not connect
> >         at
> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
> >         at
> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
> >
> >
> > Patrick
> >
> > On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]>
> wrote:
> >> Good point Ted.
> >> Eugene,
> >>  Would you be able to take a quick look and point out the threat level?
> :)
> >>
> >> I have kicked off new build to see if its reproducible or not.
> >>
> >> thanks
> >> mahadev
> >>
> >> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >>> Should ZOOKEEPER-1557 be given some time so that we track down root
> cause ?
> >>>
> >>> Thanks
> >>>
> >>> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]>
> wrote:
> >>>
> >>>> +1, sig/xsum are correct, ran rat an that looked good. All the unit
> >>>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
> >>>> 1/3/5/13 server clusters using openjdk7, everything seems to be
> >>>> working.
> >>>>
> >>>> Patrick
> >>>>
> >>>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <
> [EMAIL PROTECTED]>
> >>>> wrote:
> >>>> > Hi all,
> >>>> >
> >>>> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
> >>>> >  addressed in this release. This includes the critical bugfix
> >>>> ZOOKEEPER-1550
> >>>> >  which address the client connection issue.
> >>>> >
> >>>> >  *** Please download, test and VOTE before the
> >>>> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
> >>>> >
> >>>> > Note that I am extending the vote period for a little longer so that
> >>>> > folks get time to test this out.
> >>>> >
> >>>> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
> >>>> >
> >>>> >  Should we release this?
> >>>> >
> >>>> >  thanks
> >>>> >  mahadev
> >>>>
>

I think that was due to the following running on the same machine at the
same time:

Building remotely on ubuntu4
<https://builds.apache.org/computer/ubuntu4> in workspace
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7

We should introduce randomized port so that test suite can execute in
parallel.

Cheers

On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:

> Some tests failed in build 8 due to (See
>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/):
>
> java.lang.RuntimeException: java.net.BindException: Address already in use
> at org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
> at org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
> Caused by: java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> at sun.nio.ch.Net.bind(Net.java:344)
> at sun.nio.ch.Net.bind(Net.java:336)
> at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
> at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
> at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
> at org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
> at org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
> at org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)
>
>
>
> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>
>> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
>> jenkins and they are looking good so far:
>>
>>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
>>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/
>>
>> Patrick
>>
>> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>> > Doesn't look good, failed a second time:
>> >
>> >
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
>> >
>> > java.util.concurrent.TimeoutException: Did not connect
>> >         at
>> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
>> >         at
>> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
>> >
>> >
>> > Patrick
>> >
>> > On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]>
>> wrote:
>> >> Good point Ted.
>> >> Eugene,
>> >>  Would you be able to take a quick look and point out the threat
>> level? :)
>> >>
>> >> I have kicked off new build to see if its reproducible or not.
>> >>
>> >> thanks
>> >> mahadev
>> >>
>> >> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >>> Should ZOOKEEPER-1557 be given some time so that we track down root
>> cause ?
>> >>>
>> >>> Thanks
>> >>>
>> >>> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]>
>> wrote:
>> >>>
>> >>>> +1, sig/xsum are correct, ran rat an that looked good. All the unit
>> >>>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
>> >>>> 1/3/5/13 server clusters using openjdk7, everything seems to be
>> >>>> working.
>> >>>>
>> >>>> Patrick
>> >>>>
>> >>>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <
>> [EMAIL PROTECTED]>
>> >>>> wrote:
>> >>>> > Hi all,
>> >>>> >
>> >>>> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>> >>>> >  addressed in this release. This includes the critical bugfix
>> >>>> ZOOKEEPER-1550
>> >>>> >  which address the client connection issue.
>> >>>> >
>> >>>> >  *** Please download, test and VOTE before the
>> >>>> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>> >>>> >
>> >>>> > Note that I am extending the vote period for a little longer so
>> that
>> >>>> > folks get time to test this out.
>> >

Yes. Those ubuntu machines have two slots each. If both tests run at
the same time... bam.

I just added exclusion locks to the configuration of these two jobs,
that should help.

Patrick

On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> I think that was due to the following running on the same machine at the
> same time:
>
> Building remotely on ubuntu4
> <https://builds.apache.org/computer/ubuntu4> in workspace
> /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>
> We should introduce randomized port so that test suite can execute in
> parallel.
>
> Cheers
>
> On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>
>> Some tests failed in build 8 due to (See
>>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/):
>>
>> java.lang.RuntimeException: java.net.BindException: Address already in use
>>       at org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>>       at org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>> Caused by: java.net.BindException: Address already in use
>>       at sun.nio.ch.Net.bind0(Native Method)
>>       at sun.nio.ch.Net.bind(Net.java:344)
>>       at sun.nio.ch.Net.bind(Net.java:336)
>>       at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>>       at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>>       at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>>       at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
>>       at org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
>>       at org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
>>       at org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)
>>
>>
>>
>> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>
>>> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
>>> jenkins and they are looking good so far:
>>>
>>>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
>>>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/
>>>
>>> Patrick
>>>
>>> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>> > Doesn't look good, failed a second time:
>>> >
>>> >
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
>>> >
>>> > java.util.concurrent.TimeoutException: Did not connect
>>> >         at
>>> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
>>> >         at
>>> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
>>> >
>>> >
>>> > Patrick
>>> >
>>> > On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]>
>>> wrote:
>>> >> Good point Ted.
>>> >> Eugene,
>>> >>  Would you be able to take a quick look and point out the threat
>>> level? :)
>>> >>
>>> >> I have kicked off new build to see if its reproducible or not.
>>> >>
>>> >> thanks
>>> >> mahadev
>>> >>
>>> >> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >>> Should ZOOKEEPER-1557 be given some time so that we track down root
>>> cause ?
>>> >>>
>>> >>> Thanks
>>> >>>
>>> >>> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]>
>>> wrote:
>>> >>>
>>> >>>> +1, sig/xsum are correct, ran rat an that looked good. All the unit
>>> >>>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
>>> >>>> 1/3/5/13 server clusters using openjdk7, everything seems to be
>>> >>>> working.
>>> >>>>
>>> >>>> Patrick
>>> >>>>
>>> >>>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <
>>> [EMAIL PROTECTED]>
>>> >>>> wrote:
>>> >>>> > Hi all,
>>> >>>> >
>>> >>>> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>>> >>>> >  addressed in this release. This includes the critical bugfix

Up in ZOOKEEPER-1557, Eugene separated one test out and test failure seems
to be gone.

For ZooKeeper_branch34_jdk7, the two failed builds:
#10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
#8 corresponded to ZooKeeper_branch34_openjdk7 build #5
where tests failed due to BindException

Cheers

On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:

> Yes. Those ubuntu machines have two slots each. If both tests run at
> the same time... bam.
>
> I just added exclusion locks to the configuration of these two jobs,
> that should help.
>
> Patrick
>
> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> > I think that was due to the following running on the same machine at the
> > same time:
> >
> > Building remotely on ubuntu4
> > <https://builds.apache.org/computer/ubuntu4> in workspace
> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
> >
> > We should introduce randomized port so that test suite can execute in
> > parallel.
> >
> > Cheers
> >
> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >
> >> Some tests failed in build 8 due to (See
> >>
> >>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
> ):
> >>
> >> java.lang.RuntimeException: java.net.BindException: Address already in
> use
> >>       at
> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
> >>       at
> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
> >> Caused by: java.net.BindException: Address already in use
> >>       at sun.nio.ch.Net.bind0(Native Method)
> >>       at sun.nio.ch.Net.bind(Net.java:344)
> >>       at sun.nio.ch.Net.bind(Net.java:336)
> >>       at
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
> >>       at
> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> >>       at
> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
> >>       at
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
> >>       at
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
> >>       at
> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
> >>       at
> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)
> >>
> >>
> >>
> >> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> >>
> >>> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
> >>> jenkins and they are looking good so far:
> >>>
> >>>
> >>>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
> >>>
> >>>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/
> >>>
> >>> Patrick
> >>>
> >>> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]>
> wrote:
> >>> > Doesn't look good, failed a second time:
> >>> >
> >>> >
> >>>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
> >>> >
> >>> > java.util.concurrent.TimeoutException: Did not connect
> >>> >         at
> >>>
> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
> >>> >         at
> >>>
> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
> >>> >
> >>> >
> >>> > Patrick
> >>> >
> >>> > On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <
> [EMAIL PROTECTED]>
> >>> wrote:
> >>> >> Good point Ted.
> >>> >> Eugene,
> >>> >>  Would you be able to take a quick look and point out the threat
> >>> level? :)
> >>> >>
> >>> >> I have kicked off new build to see if its reproducible or not.
> >>> >>
> >>> >> thanks
> >>> >> mahadev
> >>> >>
> >>> >> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >>> >>> Should ZOOKEEPER-1557 be given some time so that we track down root
> >>> cause ?
> >>> >>>
> >>> >>> Thanks
> >>

I saw one test failure:

https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/

FYI

On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:

> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure seems
> to be gone.
>
> For ZooKeeper_branch34_jdk7, the two failed builds:
> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
> where tests failed due to BindException
>
> Cheers
>
>
> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>
>> Yes. Those ubuntu machines have two slots each. If both tests run at
>> the same time... bam.
>>
>> I just added exclusion locks to the configuration of these two jobs,
>> that should help.
>>
>> Patrick
>>
>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> > I think that was due to the following running on the same machine at the
>> > same time:
>> >
>> > Building remotely on ubuntu4
>> > <https://builds.apache.org/computer/ubuntu4> in workspace
>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>> >
>> > We should introduce randomized port so that test suite can execute in
>> > parallel.
>> >
>> > Cheers
>> >
>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >
>> >> Some tests failed in build 8 due to (See
>> >>
>> >>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>> ):
>> >>
>> >> java.lang.RuntimeException: java.net.BindException: Address already in
>> use
>> >>       at
>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>> >>       at
>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>> >> Caused by: java.net.BindException: Address already in use
>> >>       at sun.nio.ch.Net.bind0(Native Method)
>> >>       at sun.nio.ch.Net.bind(Net.java:344)
>> >>       at sun.nio.ch.Net.bind(Net.java:336)
>> >>       at
>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>> >>       at
>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>> >>       at
>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>> >>       at
>> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
>> >>       at
>> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
>> >>       at
>> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
>> >>       at
>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)
>> >>
>> >>
>> >>
>> >> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>> >>
>> >>> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
>> >>> jenkins and they are looking good so far:
>> >>>
>> >>>
>> >>>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
>> >>>
>> >>>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/
>> >>>
>> >>> Patrick
>> >>>
>> >>> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]>
>> wrote:
>> >>> > Doesn't look good, failed a second time:
>> >>> >
>> >>> >
>> >>>
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
>> >>> >
>> >>> > java.util.concurrent.TimeoutException: Did not connect
>> >>> >         at
>> >>>
>> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
>> >>> >         at
>> >>>
>> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
>> >>> >
>> >>> >
>> >>> > Patrick
>> >>> >
>> >>> > On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <
>> [EMAIL PROTECTED]>
>> >>> wrote:
>> >>> >> Good point Ted.
>> >>> >> Eugene,
>> >>> >>  Would you be able to take a quick look and point out the threat

I've seen that before, it's a flakey test that's unrelated to the sasl stuff.

Patrick

On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> I saw one test failure:
>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>
> FYI
>
> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>
>> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure seems
>> to be gone.
>>
>> For ZooKeeper_branch34_jdk7, the two failed builds:
>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>> where tests failed due to BindException
>>
>> Cheers
>>
>>
>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>
>>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>> the same time... bam.
>>>
>>> I just added exclusion locks to the configuration of these two jobs,
>>> that should help.
>>>
>>> Patrick
>>>
>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> > I think that was due to the following running on the same machine at the
>>> > same time:
>>> >
>>> > Building remotely on ubuntu4
>>> > <https://builds.apache.org/computer/ubuntu4> in workspace
>>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>> >
>>> > We should introduce randomized port so that test suite can execute in
>>> > parallel.
>>> >
>>> > Cheers
>>> >
>>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >
>>> >> Some tests failed in build 8 due to (See
>>> >>
>>> >>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>>> ):
>>> >>
>>> >> java.lang.RuntimeException: java.net.BindException: Address already in
>>> use
>>> >>       at
>>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>>> >>       at
>>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>>> >> Caused by: java.net.BindException: Address already in use
>>> >>       at sun.nio.ch.Net.bind0(Native Method)
>>> >>       at sun.nio.ch.Net.bind(Net.java:344)
>>> >>       at sun.nio.ch.Net.bind(Net.java:336)
>>> >>       at
>>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>>> >>       at
>>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>>> >>       at
>>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>>> >>       at
>>> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
>>> >>       at
>>> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
>>> >>       at
>>> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
>>> >>       at
>>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)
>>> >>
>>> >>
>>> >>
>>> >> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>> >>
>>> >>> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
>>> >>> jenkins and they are looking good so far:
>>> >>>
>>> >>>
>>> >>>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
>>> >>>
>>> >>>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/
>>> >>>
>>> >>> Patrick
>>> >>>
>>> >>> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]>
>>> wrote:
>>> >>> > Doesn't look good, failed a second time:
>>> >>> >
>>> >>> >
>>> >>>
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
>>> >>> >
>>> >>> > java.util.concurrent.TimeoutException: Did not connect
>>> >>> >         at
>>> >>>
>>> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
>>> >>> >         at
>>> >>>
>>> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)

Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
lock ZooKeeper-solaris.
I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
a separate lock since they wouldn't run on a Solaris machine.
I didn't seem to find how a new lock name can be added.

Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
have been green.

Cheers

On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:

> I've seen that before, it's a flakey test that's unrelated to the sasl
> stuff.
>
> Patrick
>
> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> > I saw one test failure:
> >
> >
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
> >
> > FYI
> >
> > On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >
> >> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
> seems
> >> to be gone.
> >>
> >> For ZooKeeper_branch34_jdk7, the two failed builds:
> >> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
> >> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
> >> where tests failed due to BindException
> >>
> >> Cheers
> >>
> >>
> >> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> >>
> >>> Yes. Those ubuntu machines have two slots each. If both tests run at
> >>> the same time... bam.
> >>>
> >>> I just added exclusion locks to the configuration of these two jobs,
> >>> that should help.
> >>>
> >>> Patrick
> >>>
> >>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >>> > I think that was due to the following running on the same machine at
> the
> >>> > same time:
> >>> >
> >>> > Building remotely on ubuntu4
> >>> > <https://builds.apache.org/computer/ubuntu4> in workspace
> >>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
> >>> >
> >>> > We should introduce randomized port so that test suite can execute in
> >>> > parallel.
> >>> >
> >>> > Cheers
> >>> >
> >>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >>> >
> >>> >> Some tests failed in build 8 due to (See
> >>> >>
> >>> >>
> >>>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
> >>> ):
> >>> >>
> >>> >> java.lang.RuntimeException: java.net.BindException: Address already
> in
> >>> use
> >>> >>       at
> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
> >>> >>       at
> >>>
> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
> >>> >> Caused by: java.net.BindException: Address already in use
> >>> >>       at sun.nio.ch.Net.bind0(Native Method)
> >>> >>       at sun.nio.ch.Net.bind(Net.java:344)
> >>> >>       at sun.nio.ch.Net.bind(Net.java:336)
> >>> >>       at
> >>>
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
> >>> >>       at
> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> >>> >>       at
> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
> >>> >>       at
> >>>
> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
> >>> >>       at
> >>>
> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
> >>> >>       at
> >>>
> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
> >>> >>       at
> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)
> >>> >>
> >>> >>
> >>> >>
> >>> >> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]>
> wrote:
> >>> >>
> >>> >>> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
> >>> >>> jenkins and they are looking good so far:
> >>> >>>
> >>> >>>
> >>> >>>
> >>>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/

I used zk-solaris for the time being. We'll have to have something
added for ubuntu, must be a jenkins admin only operation.

Patrick

On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
> lock ZooKeeper-solaris.
> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
> a separate lock since they wouldn't run on a Solaris machine.
> I didn't seem to find how a new lock name can be added.
>
> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
> have been green.
>
> Cheers
>
> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>
>> I've seen that before, it's a flakey test that's unrelated to the sasl
>> stuff.
>>
>> Patrick
>>
>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> > I saw one test failure:
>> >
>> >
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>> >
>> > FYI
>> >
>> > On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >
>> >> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>> seems
>> >> to be gone.
>> >>
>> >> For ZooKeeper_branch34_jdk7, the two failed builds:
>> >> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>> >> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>> >> where tests failed due to BindException
>> >>
>> >> Cheers
>> >>
>> >>
>> >> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>> >>
>> >>> Yes. Those ubuntu machines have two slots each. If both tests run at
>> >>> the same time... bam.
>> >>>
>> >>> I just added exclusion locks to the configuration of these two jobs,
>> >>> that should help.
>> >>>
>> >>> Patrick
>> >>>
>> >>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >>> > I think that was due to the following running on the same machine at
>> the
>> >>> > same time:
>> >>> >
>> >>> > Building remotely on ubuntu4
>> >>> > <https://builds.apache.org/computer/ubuntu4> in workspace
>> >>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>> >>> >
>> >>> > We should introduce randomized port so that test suite can execute in
>> >>> > parallel.
>> >>> >
>> >>> > Cheers
>> >>> >
>> >>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >>> >
>> >>> >> Some tests failed in build 8 due to (See
>> >>> >>
>> >>> >>
>> >>>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>> >>> ):
>> >>> >>
>> >>> >> java.lang.RuntimeException: java.net.BindException: Address already
>> in
>> >>> use
>> >>> >>       at
>> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>> >>> >>       at
>> >>>
>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>> >>> >> Caused by: java.net.BindException: Address already in use
>> >>> >>       at sun.nio.ch.Net.bind0(Native Method)
>> >>> >>       at sun.nio.ch.Net.bind(Net.java:344)
>> >>> >>       at sun.nio.ch.Net.bind(Net.java:336)
>> >>> >>       at
>> >>>
>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>> >>> >>       at
>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>> >>> >>       at
>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>> >>> >>       at
>> >>>
>> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
>> >>> >>       at
>> >>>
>> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
>> >>> >>       at
>> >>>
>> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517)
>> >>> >>       at
>> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113)
>> >>> >>
>> >>> >>
>> >>> >>
>> >>> >> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]>

On Sun, Oct 7, 2012 at 10:17 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> I used zk-solaris for the time being. We'll have to have something
> added for ubuntu, must be a jenkins admin only operation.

https://issues.apache.org/jira/browse/INFRA-5366

> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>> lock ZooKeeper-solaris.
>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>> a separate lock since they wouldn't run on a Solaris machine.
>> I didn't seem to find how a new lock name can be added.
>>
>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>> have been green.
>>
>> Cheers
>>
>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>
>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>> stuff.
>>>
>>> Patrick
>>>
>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> > I saw one test failure:
>>> >
>>> >
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>> >
>>> > FYI
>>> >
>>> > On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >
>>> >> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>> seems
>>> >> to be gone.
>>> >>
>>> >> For ZooKeeper_branch34_jdk7, the two failed builds:
>>> >> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>> >> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>> >> where tests failed due to BindException
>>> >>
>>> >> Cheers
>>> >>
>>> >>
>>> >> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>> >>
>>> >>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>> >>> the same time... bam.
>>> >>>
>>> >>> I just added exclusion locks to the configuration of these two jobs,
>>> >>> that should help.
>>> >>>
>>> >>> Patrick
>>> >>>
>>> >>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >>> > I think that was due to the following running on the same machine at
>>> the
>>> >>> > same time:
>>> >>> >
>>> >>> > Building remotely on ubuntu4
>>> >>> > <https://builds.apache.org/computer/ubuntu4> in workspace
>>> >>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>> >>> >
>>> >>> > We should introduce randomized port so that test suite can execute in
>>> >>> > parallel.
>>> >>> >
>>> >>> > Cheers
>>> >>> >
>>> >>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >>> >
>>> >>> >> Some tests failed in build 8 due to (See
>>> >>> >>
>>> >>> >>
>>> >>>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>>> >>> ):
>>> >>> >>
>>> >>> >> java.lang.RuntimeException: java.net.BindException: Address already
>>> in
>>> >>> use
>>> >>> >>       at
>>> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>>> >>> >>       at
>>> >>>
>>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>>> >>> >> Caused by: java.net.BindException: Address already in use
>>> >>> >>       at sun.nio.ch.Net.bind0(Native Method)
>>> >>> >>       at sun.nio.ch.Net.bind(Net.java:344)
>>> >>> >>       at sun.nio.ch.Net.bind(Net.java:336)
>>> >>> >>       at
>>> >>>
>>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>>> >>> >>       at
>>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>>> >>> >>       at
>>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>>> >>> >>       at
>>> >>>
>>> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
>>> >>> >>       at
>>> >>>
>>> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)
>>> >>> >>       at

The INFRA jira was resolved and I updated the jenkins jobs related to
this issue.

Patrick

On Mon, Oct 8, 2012 at 9:05 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> On Sun, Oct 7, 2012 at 10:17 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>> I used zk-solaris for the time being. We'll have to have something
>> added for ubuntu, must be a jenkins admin only operation.
>
> https://issues.apache.org/jira/browse/INFRA-5366
>
>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>>> lock ZooKeeper-solaris.
>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>>> a separate lock since they wouldn't run on a Solaris machine.
>>> I didn't seem to find how a new lock name can be added.
>>>
>>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>>> have been green.
>>>
>>> Cheers
>>>
>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>
>>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>>> stuff.
>>>>
>>>> Patrick
>>>>
>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>> > I saw one test failure:
>>>> >
>>>> >
>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>>> >
>>>> > FYI
>>>> >
>>>> > On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>> >
>>>> >> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>>> seems
>>>> >> to be gone.
>>>> >>
>>>> >> For ZooKeeper_branch34_jdk7, the two failed builds:
>>>> >> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>>> >> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>>> >> where tests failed due to BindException
>>>> >>
>>>> >> Cheers
>>>> >>
>>>> >>
>>>> >> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>> >>
>>>> >>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>>> >>> the same time... bam.
>>>> >>>
>>>> >>> I just added exclusion locks to the configuration of these two jobs,
>>>> >>> that should help.
>>>> >>>
>>>> >>> Patrick
>>>> >>>
>>>> >>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>> >>> > I think that was due to the following running on the same machine at
>>>> the
>>>> >>> > same time:
>>>> >>> >
>>>> >>> > Building remotely on ubuntu4
>>>> >>> > <https://builds.apache.org/computer/ubuntu4> in workspace
>>>> >>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>>> >>> >
>>>> >>> > We should introduce randomized port so that test suite can execute in
>>>> >>> > parallel.
>>>> >>> >
>>>> >>> > Cheers
>>>> >>> >
>>>> >>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>> >>> >
>>>> >>> >> Some tests failed in build 8 due to (See
>>>> >>> >>
>>>> >>> >>
>>>> >>>
>>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>>>> >>> ):
>>>> >>> >>
>>>> >>> >> java.lang.RuntimeException: java.net.BindException: Address already
>>>> in
>>>> >>> use
>>>> >>> >>       at
>>>> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>>>> >>> >>       at
>>>> >>>
>>>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>>>> >>> >> Caused by: java.net.BindException: Address already in use
>>>> >>> >>       at sun.nio.ch.Net.bind0(Native Method)
>>>> >>> >>       at sun.nio.ch.Net.bind(Net.java:344)
>>>> >>> >>       at sun.nio.ch.Net.bind(Net.java:336)
>>>> >>> >>       at
>>>> >>>
>>>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>>>> >>> >>       at
>>>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>>>> >>> >>       at
>>>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)

Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
rolling the current RC out. Others please vote on the thread if you
see any issues with that. Folks who have already voted, please re vote
in case you have a change of opinion.

As for myself, I ran a couple of tests with the RC using open jdk 7
and things seem to work.

+1 from my side. Pat/Ben/Flavio/others what do you guys think?

thanks
mahadev

On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
> lock ZooKeeper-solaris.
> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
> a separate lock since they wouldn't run on a Solaris machine.
> I didn't seem to find how a new lock name can be added.
>
> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
> have been green.
>
> Cheers
>
> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>
>> I've seen that before, it's a flakey test that's unrelated to the sasl
>> stuff.
>>
>> Patrick
>>
>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> > I saw one test failure:
>> >
>> >
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>> >
>> > FYI
>> >
>> > On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >
>> >> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>> seems
>> >> to be gone.
>> >>
>> >> For ZooKeeper_branch34_jdk7, the two failed builds:
>> >> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>> >> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>> >> where tests failed due to BindException
>> >>
>> >> Cheers
>> >>
>> >>
>> >> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>> >>
>> >>> Yes. Those ubuntu machines have two slots each. If both tests run at
>> >>> the same time... bam.
>> >>>
>> >>> I just added exclusion locks to the configuration of these two jobs,
>> >>> that should help.
>> >>>
>> >>> Patrick
>> >>>
>> >>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >>> > I think that was due to the following running on the same machine at
>> the
>> >>> > same time:
>> >>> >
>> >>> > Building remotely on ubuntu4
>> >>> > <https://builds.apache.org/computer/ubuntu4> in workspace
>> >>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>> >>> >
>> >>> > We should introduce randomized port so that test suite can execute in
>> >>> > parallel.
>> >>> >
>> >>> > Cheers
>> >>> >
>> >>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >>> >
>> >>> >> Some tests failed in build 8 due to (See
>> >>> >>
>> >>> >>
>> >>>
>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>> >>> ):
>> >>> >>
>> >>> >> java.lang.RuntimeException: java.net.BindException: Address already
>> in
>> >>> use
>> >>> >>       at
>> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>> >>> >>       at
>> >>>
>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>> >>> >> Caused by: java.net.BindException: Address already in use
>> >>> >>       at sun.nio.ch.Net.bind0(Native Method)
>> >>> >>       at sun.nio.ch.Net.bind(Net.java:344)
>> >>> >>       at sun.nio.ch.Net.bind(Net.java:336)
>> >>> >>       at
>> >>>
>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>> >>> >>       at
>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>> >>> >>       at
>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>> >>> >>       at
>> >>>
>> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
>> >>> >>       at
>> >>>
>> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125)

I used jdk6 and jdk7 and it was fine. Based on Eugene's findings I
don't see any reason not to continue, I'm still +1.

Patrick

On Sun, Oct 7, 2012 at 10:05 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
> rolling the current RC out. Others please vote on the thread if you
> see any issues with that. Folks who have already voted, please re vote
> in case you have a change of opinion.
>
> As for myself, I ran a couple of tests with the RC using open jdk 7
> and things seem to work.
>
> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
>
> thanks
> mahadev
>
> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>> lock ZooKeeper-solaris.
>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>> a separate lock since they wouldn't run on a Solaris machine.
>> I didn't seem to find how a new lock name can be added.
>>
>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>> have been green.
>>
>> Cheers
>>
>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>
>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>> stuff.
>>>
>>> Patrick
>>>
>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> > I saw one test failure:
>>> >
>>> >
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>> >
>>> > FYI
>>> >
>>> > On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >
>>> >> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>> seems
>>> >> to be gone.
>>> >>
>>> >> For ZooKeeper_branch34_jdk7, the two failed builds:
>>> >> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>> >> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>> >> where tests failed due to BindException
>>> >>
>>> >> Cheers
>>> >>
>>> >>
>>> >> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>> >>
>>> >>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>> >>> the same time... bam.
>>> >>>
>>> >>> I just added exclusion locks to the configuration of these two jobs,
>>> >>> that should help.
>>> >>>
>>> >>> Patrick
>>> >>>
>>> >>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >>> > I think that was due to the following running on the same machine at
>>> the
>>> >>> > same time:
>>> >>> >
>>> >>> > Building remotely on ubuntu4
>>> >>> > <https://builds.apache.org/computer/ubuntu4> in workspace
>>> >>> > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>> >>> >
>>> >>> > We should introduce randomized port so that test suite can execute in
>>> >>> > parallel.
>>> >>> >
>>> >>> > Cheers
>>> >>> >
>>> >>> > On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> >>> >
>>> >>> >> Some tests failed in build 8 due to (See
>>> >>> >>
>>> >>> >>
>>> >>>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>>> >>> ):
>>> >>> >>
>>> >>> >> java.lang.RuntimeException: java.net.BindException: Address already
>>> in
>>> >>> use
>>> >>> >>       at
>>> >>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>>> >>> >>       at
>>> >>>
>>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>>> >>> >> Caused by: java.net.BindException: Address already in use
>>> >>> >>       at sun.nio.ch.Net.bind0(Native Method)
>>> >>> >>       at sun.nio.ch.Net.bind(Net.java:344)
>>> >>> >>       at sun.nio.ch.Net.bind(Net.java:336)
>>> >>> >>       at
>>> >>>
>>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>>> >>> >>       at
>>> >>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)

+1

-Flavio

On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote:

> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
> rolling the current RC out. Others please vote on the thread if you
> see any issues with that. Folks who have already voted, please re vote
> in case you have a change of opinion.
>
> As for myself, I ran a couple of tests with the RC using open jdk 7
> and things seem to work.
>
> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
>
> thanks
> mahadev
>
> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>> lock ZooKeeper-solaris.
>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>> a separate lock since they wouldn't run on a Solaris machine.
>> I didn't seem to find how a new lock name can be added.
>>
>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>> have been green.
>>
>> Cheers
>>
>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>
>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>> stuff.
>>>
>>> Patrick
>>>
>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>> I saw one test failure:
>>>>
>>>>
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>>>
>>>> FYI
>>>>
>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>
>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>> seems
>>>>> to be gone.
>>>>>
>>>>> For ZooKeeper_branch34_jdk7, the two failed builds:
>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>>>> where tests failed due to BindException
>>>>>
>>>>> Cheers
>>>>>
>>>>>
>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>>
>>>>>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>>>>> the same time... bam.
>>>>>>
>>>>>> I just added exclusion locks to the configuration of these two jobs,
>>>>>> that should help.
>>>>>>
>>>>>> Patrick
>>>>>>
>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>> I think that was due to the following running on the same machine at
>>> the
>>>>>>> same time:
>>>>>>>
>>>>>>> Building remotely on ubuntu4
>>>>>>> <https://builds.apache.org/computer/ubuntu4> in workspace
>>>>>>> /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>>>>>>
>>>>>>> We should introduce randomized port so that test suite can execute in
>>>>>>> parallel.
>>>>>>>
>>>>>>> Cheers
>>>>>>>
>>>>>>> On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>
>>>>>>>> Some tests failed in build 8 due to (See
>>>>>>>>
>>>>>>>>
>>>>>>
>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>>>>>> ):
>>>>>>>>
>>>>>>>> java.lang.RuntimeException: java.net.BindException: Address already
>>> in
>>>>>> use
>>>>>>>>      at
>>>>>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>>>>>>>>      at
>>>>>>
>>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>>>>>>>> Caused by: java.net.BindException: Address already in use
>>>>>>>>      at sun.nio.ch.Net.bind0(Native Method)
>>>>>>>>      at sun.nio.ch.Net.bind(Net.java:344)
>>>>>>>>      at sun.nio.ch.Net.bind(Net.java:336)
>>>>>>>>      at
>>>>>>
>>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199)
>>>>>>>>      at
>>>>>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>>>>>>>>      at
>>>>>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
>>>>>>>>      at
>>>>>>
>>> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)

I think we have waited enough. Closing the vote now.

With 5 +1's (3 binding) the vote passes. I will do the needful for
getting the release out.

Thanks for voting folks.

mahadev

On Wed, Oct 10, 2012 at 9:04 AM, Flavio Junqueira <[EMAIL PROTECTED]> wrote:
> +1
>
> -Flavio
>
> On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote:
>
>> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
>> rolling the current RC out. Others please vote on the thread if you
>> see any issues with that. Folks who have already voted, please re vote
>> in case you have a change of opinion.
>>
>> As for myself, I ran a couple of tests with the RC using open jdk 7
>> and things seem to work.
>>
>> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
>>
>> thanks
>> mahadev
>>
>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>>> lock ZooKeeper-solaris.
>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>>> a separate lock since they wouldn't run on a Solaris machine.
>>> I didn't seem to find how a new lock name can be added.
>>>
>>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>>> have been green.
>>>
>>> Cheers
>>>
>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>
>>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>>> stuff.
>>>>
>>>> Patrick
>>>>
>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>> I saw one test failure:
>>>>>
>>>>>
>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>>>>
>>>>> FYI
>>>>>
>>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>
>>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>>> seems
>>>>>> to be gone.
>>>>>>
>>>>>> For ZooKeeper_branch34_jdk7, the two failed builds:
>>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>>>>> where tests failed due to BindException
>>>>>>
>>>>>> Cheers
>>>>>>
>>>>>>
>>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>>>
>>>>>>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>>>>>> the same time... bam.
>>>>>>>
>>>>>>> I just added exclusion locks to the configuration of these two jobs,
>>>>>>> that should help.
>>>>>>>
>>>>>>> Patrick
>>>>>>>
>>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>> I think that was due to the following running on the same machine at
>>>> the
>>>>>>>> same time:
>>>>>>>>
>>>>>>>> Building remotely on ubuntu4
>>>>>>>> <https://builds.apache.org/computer/ubuntu4> in workspace
>>>>>>>> /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>>>>>>>
>>>>>>>> We should introduce randomized port so that test suite can execute in
>>>>>>>> parallel.
>>>>>>>>
>>>>>>>> Cheers
>>>>>>>>
>>>>>>>> On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>>
>>>>>>>>> Some tests failed in build 8 due to (See
>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>>>>>>> ):
>>>>>>>>>
>>>>>>>>> java.lang.RuntimeException: java.net.BindException: Address already
>>>> in
>>>>>>> use
>>>>>>>>>      at
>>>>>>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)
>>>>>>>>>      at
>>>>>>>
>>>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63)
>>>>>>>>> Caused by: java.net.BindException: Address already in use
>>>>>>>>>      at sun.nio.ch.Net.bind0(Native Method)
>>>>>>>>>      at sun.nio.ch.Net.bind(Net.java:344)
>>>>>>>>>      at sun.nio.ch.Net.bind(Net.java:336)
>>>>>>>>>      at

Hi Mahadev,

ZOOKEEPER-1560 and ZOOKEEPER-1561 indicate a potentially serious issue,
introduced recently in ZOOKEEPER-1437. Please consider this w.r.t. the
3.4.5 release.

Best Regards,
Alex

On Wed, Oct 10, 2012 at 10:38 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> I think we have waited enough. Closing the vote now.
>
> With 5 +1's (3 binding) the vote passes. I will do the needful for
> getting the release out.
>
> Thanks for voting folks.
>
> mahadev
>
> On Wed, Oct 10, 2012 at 9:04 AM, Flavio Junqueira <[EMAIL PROTECTED]> wrote:
>> +1
>>
>> -Flavio
>>
>> On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote:
>>
>>> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
>>> rolling the current RC out. Others please vote on the thread if you
>>> see any issues with that. Folks who have already voted, please re vote
>>> in case you have a change of opinion.
>>>
>>> As for myself, I ran a couple of tests with the RC using open jdk 7
>>> and things seem to work.
>>>
>>> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
>>>
>>> thanks
>>> mahadev
>>>
>>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>>>> lock ZooKeeper-solaris.
>>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>>>> a separate lock since they wouldn't run on a Solaris machine.
>>>> I didn't seem to find how a new lock name can be added.
>>>>
>>>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>>>> have been green.
>>>>
>>>> Cheers
>>>>
>>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>
>>>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>>>> stuff.
>>>>>
>>>>> Patrick
>>>>>
>>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>> I saw one test failure:
>>>>>>
>>>>>>
>>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>>>>>
>>>>>> FYI
>>>>>>
>>>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>
>>>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>>>> seems
>>>>>>> to be gone.
>>>>>>>
>>>>>>> For ZooKeeper_branch34_jdk7, the two failed builds:
>>>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>>>>>> where tests failed due to BindException
>>>>>>>
>>>>>>> Cheers
>>>>>>>
>>>>>>>
>>>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>>>>
>>>>>>>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>>>>>>> the same time... bam.
>>>>>>>>
>>>>>>>> I just added exclusion locks to the configuration of these two jobs,
>>>>>>>> that should help.
>>>>>>>>
>>>>>>>> Patrick
>>>>>>>>
>>>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>>> I think that was due to the following running on the same machine at
>>>>> the
>>>>>>>>> same time:
>>>>>>>>>
>>>>>>>>> Building remotely on ubuntu4
>>>>>>>>> <https://builds.apache.org/computer/ubuntu4> in workspace
>>>>>>>>> /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>>>>>>>>
>>>>>>>>> We should introduce randomized port so that test suite can execute in
>>>>>>>>> parallel.
>>>>>>>>>
>>>>>>>>> Cheers
>>>>>>>>>
>>>>>>>>> On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>>>
>>>>>>>>>> Some tests failed in build 8 due to (See
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/
>>>>>>>> ):
>>>>>>>>>>
>>>>>>>>>> java.lang.RuntimeException: java.net.BindException: Address already
>>>>> in
>>>>>>>> use
>>>>>>>>>>      at
>>>>>>>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118)

Thanks Alex for bringing it up. Ill hold the release for now. I see a
patch on 1560. Ill take a look and we'll see how to roll this into
3.4.5.

thanks
mahadev

On Thu, Oct 11, 2012 at 2:42 PM, Alexander Shraer <[EMAIL PROTECTED]> wrote:
> Hi Mahadev,
>
> ZOOKEEPER-1560 and ZOOKEEPER-1561 indicate a potentially serious issue,
> introduced recently in ZOOKEEPER-1437. Please consider this w.r.t. the
> 3.4.5 release.
>
> Best Regards,
> Alex
>
> On Wed, Oct 10, 2012 at 10:38 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>> I think we have waited enough. Closing the vote now.
>>
>> With 5 +1's (3 binding) the vote passes. I will do the needful for
>> getting the release out.
>>
>> Thanks for voting folks.
>>
>> mahadev
>>
>> On Wed, Oct 10, 2012 at 9:04 AM, Flavio Junqueira <[EMAIL PROTECTED]> wrote:
>>> +1
>>>
>>> -Flavio
>>>
>>> On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote:
>>>
>>>> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
>>>> rolling the current RC out. Others please vote on the thread if you
>>>> see any issues with that. Folks who have already voted, please re vote
>>>> in case you have a change of opinion.
>>>>
>>>> As for myself, I ran a couple of tests with the RC using open jdk 7
>>>> and things seem to work.
>>>>
>>>> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
>>>>
>>>> thanks
>>>> mahadev
>>>>
>>>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>>>>> lock ZooKeeper-solaris.
>>>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>>>>> a separate lock since they wouldn't run on a Solaris machine.
>>>>> I didn't seem to find how a new lock name can be added.
>>>>>
>>>>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>>>>> have been green.
>>>>>
>>>>> Cheers
>>>>>
>>>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>>
>>>>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>>>>> stuff.
>>>>>>
>>>>>> Patrick
>>>>>>
>>>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>> I saw one test failure:
>>>>>>>
>>>>>>>
>>>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>>>>>>
>>>>>>> FYI
>>>>>>>
>>>>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>
>>>>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>>>>> seems
>>>>>>>> to be gone.
>>>>>>>>
>>>>>>>> For ZooKeeper_branch34_jdk7, the two failed builds:
>>>>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>>>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>>>>>>> where tests failed due to BindException
>>>>>>>>
>>>>>>>> Cheers
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>>>>>
>>>>>>>>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>>>>>>>> the same time... bam.
>>>>>>>>>
>>>>>>>>> I just added exclusion locks to the configuration of these two jobs,
>>>>>>>>> that should help.
>>>>>>>>>
>>>>>>>>> Patrick
>>>>>>>>>
>>>>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>>>> I think that was due to the following running on the same machine at
>>>>>> the
>>>>>>>>>> same time:
>>>>>>>>>>
>>>>>>>>>> Building remotely on ubuntu4
>>>>>>>>>> <https://builds.apache.org/computer/ubuntu4> in workspace
>>>>>>>>>> /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>>>>>>>>>
>>>>>>>>>> We should introduce randomized port so that test suite can execute in
>>>>>>>>>> parallel.
>>>>>>>>>>
>>>>>>>>>> Cheers
>>>>>>>>>>
>>>>>>>>>> On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Some tests failed in build 8 due to (See
>>>>>>>>>>>
>>>>>>>>>>>
>>>>

Patch v7 for ZOOKEEPER-1560 passes test suite.

Please take a look.

On Thu, Oct 11, 2012 at 2:45 PM, Mahadev Konar <[EMAIL PROTECTED]>wrote:

> Thanks Alex for bringing it up. Ill hold the release for now. I see a
> patch on 1560. Ill take a look and we'll see how to roll this into
> 3.4.5.
>
> thanks
> mahadev
>
> On Thu, Oct 11, 2012 at 2:42 PM, Alexander Shraer <[EMAIL PROTECTED]>
> wrote:
> > Hi Mahadev,
> >
> > ZOOKEEPER-1560 and ZOOKEEPER-1561 indicate a potentially serious issue,
> > introduced recently in ZOOKEEPER-1437. Please consider this w.r.t. the
> > 3.4.5 release.
> >
> > Best Regards,
> > Alex
> >
> > On Wed, Oct 10, 2012 at 10:38 PM, Mahadev Konar <[EMAIL PROTECTED]>
> wrote:
> >> I think we have waited enough. Closing the vote now.
> >>
> >> With 5 +1's (3 binding) the vote passes. I will do the needful for
> >> getting the release out.
> >>
> >> Thanks for voting folks.
> >>
> >> mahadev
> >>
> >> On Wed, Oct 10, 2012 at 9:04 AM, Flavio Junqueira <[EMAIL PROTECTED]>
> wrote:
> >>> +1
> >>>
> >>> -Flavio
> >>>
> >>> On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote:
> >>>
> >>>> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
> >>>> rolling the current RC out. Others please vote on the thread if you
> >>>> see any issues with that. Folks who have already voted, please re vote
> >>>> in case you have a change of opinion.
> >>>>
> >>>> As for myself, I ran a couple of tests with the RC using open jdk 7
> >>>> and things seem to work.
> >>>>
> >>>> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
> >>>>
> >>>> thanks
> >>>> mahadev
> >>>>
> >>>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >>>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
> are using
> >>>>> lock ZooKeeper-solaris.
> >>>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
> should use
> >>>>> a separate lock since they wouldn't run on a Solaris machine.
> >>>>> I didn't seem to find how a new lock name can be added.
> >>>>>
> >>>>> Recent builds for ZooKeeper_branch34_openjdk7 and
> ZooKeeper_branch34_jdk7
> >>>>> have been green.
> >>>>>
> >>>>> Cheers
> >>>>>
> >>>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]>
> wrote:
> >>>>>
> >>>>>> I've seen that before, it's a flakey test that's unrelated to the
> sasl
> >>>>>> stuff.
> >>>>>>
> >>>>>> Patrick
> >>>>>>
> >>>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >>>>>>> I saw one test failure:
> >>>>>>>
> >>>>>>>
> >>>>>>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
> >>>>>>>
> >>>>>>> FYI
> >>>>>>>
> >>>>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]>
> wrote:
> >>>>>>>
> >>>>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test
> failure
> >>>>>> seems
> >>>>>>>> to be gone.
> >>>>>>>>
> >>>>>>>> For ZooKeeper_branch34_jdk7, the two failed builds:
> >>>>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
> >>>>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
> >>>>>>>> where tests failed due to BindException
> >>>>>>>>
> >>>>>>>> Cheers
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]>
> wrote:
> >>>>>>>>
> >>>>>>>>> Yes. Those ubuntu machines have two slots each. If both tests
> run at
> >>>>>>>>> the same time... bam.
> >>>>>>>>>
> >>>>>>>>> I just added exclusion locks to the configuration of these two
> jobs,
> >>>>>>>>> that should help.
> >>>>>>>>>
> >>>>>>>>> Patrick
> >>>>>>>>>
> >>>>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]>
> wrote:
> >>>>>>>>>> I think that was due to the following running on the same
> machine at
> >>>>>> the
> >>>>>>>>>> same time:
> >>>>>>>>>>
> >>>>>>>>>> Building remotely on ubuntu4
> >>>>>>>>>> <https://builds.apache.org/computer/ubuntu4> in workspace
> >>>>>>>>>>

Thanks Ted. Will review the changes over the weekend.

Thanks again
mahadev

On Fri, Oct 12, 2012 at 1:12 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
> Patch v7 for ZOOKEEPER-1560 passes test suite.
>
> Please take a look.
>
> On Thu, Oct 11, 2012 at 2:45 PM, Mahadev Konar <[EMAIL PROTECTED]>wrote:
>
>> Thanks Alex for bringing it up. Ill hold the release for now. I see a
>> patch on 1560. Ill take a look and we'll see how to roll this into
>> 3.4.5.
>>
>> thanks
>> mahadev
>>
>> On Thu, Oct 11, 2012 at 2:42 PM, Alexander Shraer <[EMAIL PROTECTED]>
>> wrote:
>> > Hi Mahadev,
>> >
>> > ZOOKEEPER-1560 and ZOOKEEPER-1561 indicate a potentially serious issue,
>> > introduced recently in ZOOKEEPER-1437. Please consider this w.r.t. the
>> > 3.4.5 release.
>> >
>> > Best Regards,
>> > Alex
>> >
>> > On Wed, Oct 10, 2012 at 10:38 PM, Mahadev Konar <[EMAIL PROTECTED]>
>> wrote:
>> >> I think we have waited enough. Closing the vote now.
>> >>
>> >> With 5 +1's (3 binding) the vote passes. I will do the needful for
>> >> getting the release out.
>> >>
>> >> Thanks for voting folks.
>> >>
>> >> mahadev
>> >>
>> >> On Wed, Oct 10, 2012 at 9:04 AM, Flavio Junqueira <[EMAIL PROTECTED]>
>> wrote:
>> >>> +1
>> >>>
>> >>> -Flavio
>> >>>
>> >>> On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote:
>> >>>
>> >>>> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
>> >>>> rolling the current RC out. Others please vote on the thread if you
>> >>>> see any issues with that. Folks who have already voted, please re vote
>> >>>> in case you have a change of opinion.
>> >>>>
>> >>>> As for myself, I ran a couple of tests with the RC using open jdk 7
>> >>>> and things seem to work.
>> >>>>
>> >>>> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
>> >>>>
>> >>>> thanks
>> >>>> mahadev
>> >>>>
>> >>>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >>>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>> are using
>> >>>>> lock ZooKeeper-solaris.
>> >>>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>> should use
>> >>>>> a separate lock since they wouldn't run on a Solaris machine.
>> >>>>> I didn't seem to find how a new lock name can be added.
>> >>>>>
>> >>>>> Recent builds for ZooKeeper_branch34_openjdk7 and
>> ZooKeeper_branch34_jdk7
>> >>>>> have been green.
>> >>>>>
>> >>>>> Cheers
>> >>>>>
>> >>>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]>
>> wrote:
>> >>>>>
>> >>>>>> I've seen that before, it's a flakey test that's unrelated to the
>> sasl
>> >>>>>> stuff.
>> >>>>>>
>> >>>>>> Patrick
>> >>>>>>
>> >>>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> >>>>>>> I saw one test failure:
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>> >>>>>>>
>> >>>>>>> FYI
>> >>>>>>>
>> >>>>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]>
>> wrote:
>> >>>>>>>
>> >>>>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test
>> failure
>> >>>>>> seems
>> >>>>>>>> to be gone.
>> >>>>>>>>
>> >>>>>>>> For ZooKeeper_branch34_jdk7, the two failed builds:
>> >>>>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>> >>>>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>> >>>>>>>> where tests failed due to BindException
>> >>>>>>>>
>> >>>>>>>> Cheers
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]>
>> wrote:
>> >>>>>>>>
>> >>>>>>>>> Yes. Those ubuntu machines have two slots each. If both tests
>> run at
>> >>>>>>>>> the same time... bam.
>> >>>>>>>>>
>> >>>>>>>>> I just added exclusion locks to the configuration of these two
>> jobs,
>> >>>>>>>>> that should help.
>> >>>>>>>>>
>> >>>>>>>>> Patrick
>> >>>>>>>>>
>> >>>>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]>

Thanks Mahadev. It looks like the patch on 1560 is not a fix - its a
test that reproduces the bug.

On Thu, Oct 11, 2012 at 2:45 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
> Thanks Alex for bringing it up. Ill hold the release for now. I see a
> patch on 1560. Ill take a look and we'll see how to roll this into
> 3.4.5.
>
> thanks
> mahadev
>
> On Thu, Oct 11, 2012 at 2:42 PM, Alexander Shraer <[EMAIL PROTECTED]> wrote:
>> Hi Mahadev,
>>
>> ZOOKEEPER-1560 and ZOOKEEPER-1561 indicate a potentially serious issue,
>> introduced recently in ZOOKEEPER-1437. Please consider this w.r.t. the
>> 3.4.5 release.
>>
>> Best Regards,
>> Alex
>>
>> On Wed, Oct 10, 2012 at 10:38 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>> I think we have waited enough. Closing the vote now.
>>>
>>> With 5 +1's (3 binding) the vote passes. I will do the needful for
>>> getting the release out.
>>>
>>> Thanks for voting folks.
>>>
>>> mahadev
>>>
>>> On Wed, Oct 10, 2012 at 9:04 AM, Flavio Junqueira <[EMAIL PROTECTED]> wrote:
>>>> +1
>>>>
>>>> -Flavio
>>>>
>>>> On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote:
>>>>
>>>>> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue
>>>>> rolling the current RC out. Others please vote on the thread if you
>>>>> see any issues with that. Folks who have already voted, please re vote
>>>>> in case you have a change of opinion.
>>>>>
>>>>> As for myself, I ran a couple of tests with the RC using open jdk 7
>>>>> and things seem to work.
>>>>>
>>>>> +1 from my side. Pat/Ben/Flavio/others what do you guys think?
>>>>>
>>>>> thanks
>>>>> mahadev
>>>>>
>>>>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are using
>>>>>> lock ZooKeeper-solaris.
>>>>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should use
>>>>>> a separate lock since they wouldn't run on a Solaris machine.
>>>>>> I didn't seem to find how a new lock name can be added.
>>>>>>
>>>>>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7
>>>>>> have been green.
>>>>>>
>>>>>> Cheers
>>>>>>
>>>>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>>>
>>>>>>> I've seen that before, it's a flakey test that's unrelated to the sasl
>>>>>>> stuff.
>>>>>>>
>>>>>>> Patrick
>>>>>>>
>>>>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>> I saw one test failure:
>>>>>>>>
>>>>>>>>
>>>>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/
>>>>>>>>
>>>>>>>> FYI
>>>>>>>>
>>>>>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>>
>>>>>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure
>>>>>>> seems
>>>>>>>>> to be gone.
>>>>>>>>>
>>>>>>>>> For ZooKeeper_branch34_jdk7, the two failed builds:
>>>>>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7,
>>>>>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5
>>>>>>>>> where tests failed due to BindException
>>>>>>>>>
>>>>>>>>> Cheers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>>>>>>
>>>>>>>>>> Yes. Those ubuntu machines have two slots each. If both tests run at
>>>>>>>>>> the same time... bam.
>>>>>>>>>>
>>>>>>>>>> I just added exclusion locks to the configuration of these two jobs,
>>>>>>>>>> that should help.
>>>>>>>>>>
>>>>>>>>>> Patrick
>>>>>>>>>>
>>>>>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>>>>>>>>> I think that was due to the following running on the same machine at
>>>>>>> the
>>>>>>>>>>> same time:
>>>>>>>>>>>
>>>>>>>>>>> Building remotely on ubuntu4
>>>>>>>>>>> <https://builds.apache.org/computer/ubuntu4> in workspace
>>>>>>>>>>> /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
>>>>>>>>>>>
>>>>>>>>>>> We should introduce randomized port so that test suite can execute in

I spoke too soon, it seems the correct jdk version is not being used,
I'm looking into it.

Patrick

On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on
> jenkins and they are looking good so far:
>
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/
> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/
>
> Patrick
>
> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>> Doesn't look good, failed a second time:
>>
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/
>>
>> java.util.concurrent.TimeoutException: Did not connect
>>         at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129)
>>         at org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199)
>>
>>
>> Patrick
>>
>> On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar <[EMAIL PROTECTED]> wrote:
>>> Good point Ted.
>>> Eugene,
>>>  Would you be able to take a quick look and point out the threat level? :)
>>>
>>> I have kicked off new build to see if its reproducible or not.
>>>
>>> thanks
>>> mahadev
>>>
>>> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <[EMAIL PROTECTED]> wrote:
>>>> Should ZOOKEEPER-1557 be given some time so that we track down root cause ?
>>>>
>>>> Thanks
>>>>
>>>> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt <[EMAIL PROTECTED]> wrote:
>>>>
>>>>> +1, sig/xsum are correct, ran rat an that looked good. All the unit
>>>>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also ran
>>>>> 1/3/5/13 server clusters using openjdk7, everything seems to be
>>>>> working.
>>>>>
>>>>> Patrick
>>>>>
>>>>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar <[EMAIL PROTECTED]>
>>>>> wrote:
>>>>> > Hi all,
>>>>> >
>>>>> >   I have created a candidate build for ZooKeeper 3.4.5. 2 JIRAs are
>>>>> >  addressed in this release. This includes the critical bugfix
>>>>> ZOOKEEPER-1550
>>>>> >  which address the client connection issue.
>>>>> >
>>>>> >  *** Please download, test and VOTE before the
>>>>> >  *** vote closes  12:00  midnight PT on Friday, Oct 5th.***
>>>>> >
>>>>> > Note that I am extending the vote period for a little longer so that
>>>>> > folks get time to test this out.
>>>>> >
>>>>> >  http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/
>>>>> >
>>>>> >  Should we release this?
>>>>> >
>>>>> >  thanks
>>>>> >  mahadev
>>>>>

Hi all,

  I have created a candidate build for ZooKeeper 3.4.5. This includes
the fix for ZOOKEEPER-1560.
 Please take a look at the release notes for the jira list.

 *** Please download, test and VOTE before the
 *** vote closes  12:00  midnight PT on Friday, Nov 9th.***

 http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-1/

 Should we release this?

 thanks
 mahadev