Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 15857: ACCUMULO-1931 - Javadoc for core.data


Copy link to this message
-
Re: Review Request 15857: ACCUMULO-1931 - Javadoc for core.data
Sean Busbey 2013-11-27, 08:43

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15857/#review29477
-----------------------------------------------------------

core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java
<https://reviews.apache.org/r/15857/#comment56714>

    s/invalide/invalid
    
    Actually "out of bounds for the given byte array" would be clearer.

core/src/main/java/org/apache/accumulo/core/data/ArrayByteSequence.java
<https://reviews.apache.org/r/15857/#comment56715>

    This is not quite correct. If there isn't a backing array, the function does a relative bulk get for all remaining bytes in the buffer.
    
    It won't get bytes in the buffer from before the current position, nor after the current limit.

core/src/main/java/org/apache/accumulo/core/data/Column.java
<https://reviews.apache.org/r/15857/#comment56716>

    worth noting that the member is passed back directly and is thus modifiable by the caller?

core/src/main/java/org/apache/accumulo/core/data/Column.java
<https://reviews.apache.org/r/15857/#comment56717>

    worth noting that the member is passed back directly and is thus modifiable by the caller?

core/src/main/java/org/apache/accumulo/core/data/Column.java
<https://reviews.apache.org/r/15857/#comment56718>

    worth noting that the member is passed back directly and is thus modifiable by the caller?

core/src/main/java/org/apache/accumulo/core/data/Column.java
<https://reviews.apache.org/r/15857/#comment56719>

    and nulls are treated as empty strings.

core/src/main/java/org/apache/accumulo/core/data/ColumnUpdate.java
<https://reviews.apache.org/r/15857/#comment56720>

    worth noting that the member is passed back directly and is thus modifiable by the caller?

core/src/main/java/org/apache/accumulo/core/data/ColumnUpdate.java
<https://reviews.apache.org/r/15857/#comment56721>

    worth noting that the member is passed back directly and is thus modifiable by the caller?

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56725>

    visibility is set to an empty byte array, not null.

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56726>

    visibility is set to an empty byte array, not null.

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56727>

    visibility is set to an empty byte array, not null.

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56728>

    visibility is set to an empty byte array, not null.

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56729>

    s/Inorder/In order

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56730>

    s/Inorder/In order

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56731>

    s/Inorder/In order

core/src/main/java/org/apache/accumulo/core/data/Condition.java
<https://reviews.apache.org/r/15857/#comment56732>

    s/Inorder/In order

core/src/main/java/org/apache/accumulo/core/data/Key.java
<https://reviews.apache.org/r/15857/#comment56733>

    worth pointing out that it's printable when considering the byte array as ASCII.

core/src/main/java/org/apache/accumulo/core/data/Key.java
<https://reviews.apache.org/r/15857/#comment56734>

    worth pointing out that it's printable when considering the byte array as ASCII.

core/src/main/java/org/apache/accumulo/core/data/Key.java
<https://reviews.apache.org/r/15857/#comment56736>

    worth pointing out that it's turning it into a string when considering the bytes as ASCII.
    
    also a pointer to the caveats on appendPrintableString?

core/src/main/java/org/apache/accumulo/core/data/Key.java
<https://reviews.apache.org/r/15857/#comment56735>

    s/coliumn/column

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56761>

    Worth noting that a delete marker will hide any entries for that row column with an earlier timestamp? And that Accumulo will eventually remove said data from disk as a part of normal garbage collection?

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56737>

    Any chance for @since markers on these versions, or a pointer here to their details / differences?

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56738>

    note that the buffer will be copied?

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56739>

    note that the buffer will be copied?

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56740>

    note that the Text contents will be copied?

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56741>

    will have an empty visibility string.
    
    will have a timestamp set when received by a tablet server

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56743>

    will have a timestamp set when received by a tablet server

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56742>

    will have an empty visibility string

core/src/main/java/org/apache/accumulo/core/data/Mutation.java
<https://reviews.apache.org/r/15857/#comment56744>

    will only match an empty visibility string.
    
    will have a timestamp set when received by a tablet server

core/src/main/java/org/apache/accumulo