Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill, mail # dev - Review Request 13760: DRILL abs() function implementation


+
Tanujit Ghosh 2013-08-23, 03:42
+
Tanujit Ghosh 2013-08-23, 04:18
Copy link to this message
-
Re: Review Request 13760: DRILL abs() function implementation
Tanujit Ghosh 2013-08-27, 02:19
Gentle reminder.
On Fri, Aug 23, 2013 at 9:48 AM, Tanujit Ghosh <[EMAIL PROTECTED]>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13760/
>   Review request for drill.
> By Tanujit Ghosh.
>
> *Updated Aug. 23, 2013, 4:18 a.m.*
> Changes
>
> Uploaded the diff again as i had made a mistake the first time
>
>   *Repository: * drill-git
> Description
>
> Implementation of the abs() function within DRILL.
>
>   Testing
>
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
>
>   Diffs (updated)
>
>    - sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java
>    (311e715)
>    - sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java
>    (78630ba)
>    - sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java
>    (ce5dccd)
>    - sandbox/prototype/exec/java-exec/src/test/resources/functions/testMathFunctions.json
>    (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/13760/diff/>
>

--
Regards,
Tanujit