Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: Added new config 'shell' for Exec source


Copy link to this message
-
Re: Review Request: Added new config 'shell' for Exec source
Brock Noland 2012-11-03, 03:51

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7748/#review13073
-----------------------------------------------------------

flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
<https://reviews.apache.org/r/7748/#comment28130>

    Let's not hard code /tmp. Files.createTempDir() works well/
- Brock Noland
On Nov. 3, 2012, 12:02 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7748/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2012, 12:02 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added new optional config directive 'shell' for Exec Source. One can specify how to invoke a shell to run the command (e.g. /bin/sh -c) . This is only needed for commands that use features like wildcards, backticks, pipes, etc that are supported by the shell.
>
>
> This addresses bug https://issues.apache.org/jira/browse/FLUME-1661.
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1661
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 46f672f
>   flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java 0ba0508
>   flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 8bcf320
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 29ead84
>
> Diff: https://reviews.apache.org/r/7748/diff/
>
>
> Testing
> -------
>
> Have added a few test cases for both simple and more complex commands.
>
>
> Thanks,
>
> Roshan Naik
>
>