Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Review Request: PIG-3141 [piggybank] Giving CSVExcelStorage an option to handle header rows


Copy link to this message
-
Re: Review Request: PIG-3141 [piggybank] Giving CSVExcelStorage an option to handle header rows


> On March 20, 2013, 7:05 p.m., Cheolsoo Park wrote:
> > contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/CSVExcelStorage.java, line 538
> > <https://reviews.apache.org/r/9697/diff/2/?file=263987#file263987line538>
> >
> >     Can you move this line to inside the if block? That's more intuitive to me.

Actually, I just realized that I was thinking wrong about this. Please ignore my comment.
> On March 20, 2013, 7:05 p.m., Cheolsoo Park wrote:
> > contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/CSVExcelStorage.java, line 442
> > <https://reviews.apache.org/r/9697/diff/2/?file=263987#file263987line442>
> >
> >     Can you move this line to inside the if block? That's more intuitive to me.

Actually, I just realized that I was thinking wrong about this. Please ignore my comment.
- Cheolsoo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9697/#review18100
-----------------------------------------------------------
On March 1, 2013, 2:52 p.m., Jonathan Packer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9697/
> -----------------------------------------------------------
>
> (Updated March 1, 2013, 2:52 p.m.)
>
>
> Review request for pig.
>
>
> Description
> -------
>
> Reviewboard for https://issues.apache.org/jira/browse/PIG-3141
>
> Adds a "header treatment" option to CSVExcelStorage allowing header rows (first row with column names) in files to be skipped when loading, or for a header row with column names to be written when storing. Should be backwards compatible--all unit-tests from the old CSVExcelStorage pass.
>
>
> Diffs
> -----
>
>   contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/CSVExcelStorage.java 568b3f3
>   contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestCSVExcelStorage.java 9bed527
>
> Diff: https://reviews.apache.org/r/9697/diff/
>
>
> Testing
> -------
>
> cd contrib/piggybank/java
> ant -Dtestcase=TestCSVExcelStorage test
>
>
> Thanks,
>
> Jonathan Packer
>
>