Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-841 Sqoop2: Remove final keyword from manager classes


Copy link to this message
-
Re: Review Request: SQOOP-841 Sqoop2: Remove final keyword from manager classes
Venkat Ranganathan 2013-01-23, 21:41

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9067/#review15623
-----------------------------------------------------------

Ship it!
- Venkat Ranganathan
On Jan. 23, 2013, 4:32 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9067/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 4:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've removed the final keyword.
>
>
> This addresses bug SQOOP-841.
>     https://issues.apache.org/jira/browse/SQOOP-841
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 2d328561e7cd858b6d74bb05ac5eeeada1525204
>   core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 82ef8571cdc78ed17fecdebb7bf8cda2266b077e
>   core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 4d48b274fe0cd16c885a1a7c37d3fc779677379d
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 50bad30ecd0722affa864fea7eee1a10905852bf
>
> Diff: https://reviews.apache.org/r/9067/diff/
>
>
> Testing
> -------
>
> Tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>