Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-895 Sqoop2: Do not serialize framework and connector configurations into mapreduce configuration object


+
Jarek Cecho 2013-04-08, 01:11
Copy link to this message
-
Re: Review Request: SQOOP-895 Sqoop2: Do not serialize framework and connector configurations into mapreduce configuration object
Venkat Ranganathan 2013-04-10, 00:27

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10332/#review18913
-----------------------------------------------------------
It looks fine otherwise

Thanks
Venkat
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
<https://reviews.apache.org/r/10332/#comment39391>

    Nit: Indentation seems to be off
- Venkat Ranganathan
On April 8, 2013, 1:11 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10332/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 1:11 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've used mapreduce credentials cache to store the configuration objects similarly as we did in SQOOP-914.
>
>
> This addresses bug SQOOP-895.
>     https://issues.apache.org/jira/browse/SQOOP-895
>
>
> Diffs
> -----
>
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java e16a2c4
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 4aa2128
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 77f30ea
>
> Diff: https://reviews.apache.org/r/10332/diff/
>
>
> Testing
> -------
>
> Unit and integration tests seems to be passing. I've also verified the changes on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2013-04-14, 03:40
+
Kathleen Ting 2013-04-14, 22:36