Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to SinkType


+
Israel Ekpo 2013-04-13, 13:14
Copy link to this message
-
Re: Review Request: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to SinkType

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/#review19371
-----------------------------------------------------------
Israel, looks good to me. A couple of requests:
1. Please specify the testing done to ensure that this works.
2. Please update the Flume User Guide to document these new aliases.
3. Please clean up the end-of-line whitespace (highlighted here in red) and attach your patch to the JIRA.

Regards,
Mike

- Mike Percy
On April 13, 2013, 1:14 p.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10445/
> -----------------------------------------------------------
>
> (Updated April 13, 2013, 1:14 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Modified SyncType and SinkConfiguration to support this improvement.
>
>
> This addresses bug FLUME-1889.
>     https://issues.apache.org/jira/browse/FLUME-1889
>
>
> Diffs
> -----
>
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
>
> Diff: https://reviews.apache.org/r/10445/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Israel Ekpo
>
>

+
Israel Ekpo 2013-04-24, 11:33
+
Israel Ekpo 2013-04-24, 11:33
+
Israel Ekpo 2013-04-24, 11:35
+
Hari Shreedharan 2013-04-30, 05:03