Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Re: Review Request 11588: Sqoop2: Export sub directories option


Copy link to this message
-
Re: Review Request 11588: Sqoop2: Export sub directories option


> On June 9, 2013, 3:39 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java, line 31
> > <https://reviews.apache.org/r/11588/diff/3/?file=300448#file300448line31>
> >
> >     It seems to me that using Enum for simple boolean input is unnecessary overhead. We are adding support for Boolen model type in SQOOP-1076, but the patch is not yet committed. Do you think that it would make sense to wait and use that instead of the Enum?

Hi Vasanth,
SQOOP-1076 is already committed, so feel free to take advantage of it!

Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11588/#review21503
-----------------------------------------------------------
On June 4, 2013, 11:58 a.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11588/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 11:58 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1063
>     https://issues.apache.org/jira/browse/SQOOP-1063
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
>
> Introducing new option for exporting the sub directories of the given input directory.
>
> Added new input
> Input configuration
>
> Input directory: /input
> Recursive:
>   0 : NO
>   1 : YES
> Choose: 0
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java d5cbeec
>   core/src/main/resources/framework-resources.properties cebc90e
>   docs/src/site/sphinx/ClientAPI.rst 4f3fda6
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartitioner.java b3590dc
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java b3e6050
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0e8c9f7
>
> Diff: https://reviews.apache.org/r/11588/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>