Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Re: Review Request: Support for optional channels in MultiplexingChannelSelector


Copy link to this message
-
Re: Review Request: Support for optional channels in MultiplexingChannelSelector

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4034/#review12874
-----------------------------------------------------------
Hi,

The patch fails to apply. Can you rebase it?

patching file flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java
Hunk #1 FAILED at 38.
Hunk #4 succeeded at 119 (offset -1 lines).
1 out of 4 hunks FAILED -- saving rejects to file flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java.rej
patching file flume-ng-core/src/test/java/org/apache/flume/channel/TestMultiplexingChannelSelector.java
- Brock Noland
On Feb. 24, 2012, 7 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4034/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2012, 7 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Support for optional channels in multiplexing channel selector. If no required channels configured, but there are optional channels then it means, write to default channels and optionally write to optional channels if they are available.
>
>
> This addresses bug FLUME-946.
>     https://issues.apache.org/jira/browse/FLUME-946
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java c63d0a1
>   flume-ng-core/src/test/java/org/apache/flume/channel/TestMultiplexingChannelSelector.java 2626b20
>
> Diff: https://reviews.apache.org/r/4034/diff/
>
>
> Testing
> -------
>
> Updated unit tests to support these cases
>
>
> Thanks,
>
> Hari Shreedharan
>
>