Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: Add average events per second params to MBeans


Copy link to this message
-
Review Request: Add average events per second params to MBeans

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7112/
-----------------------------------------------------------

Review request for Flume.
Description
-------

This is not a completely finished patch but an example of a possible solution. If you like the solution I'll finish the patch.

This solution supports two types of averages:
1. Averages since start
2. Rolling Averages (The rolling interval can be set through config properties)

I added two gets for these averages in sinkCounter.

I also added a junit that tests both of these averages and shows how quickly they deviate.
Please let me know what you think.
This addresses bug FLUME-1411.
    https://issues.apache.org/jira/browse/FLUME-1411
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java 6bc31ef
  flume-ng-core/src/main/java/org/apache/flume/instrumentation/SinkCounter.java 41b28cf
  flume-ng-core/src/test/java/org/apache/flume/instrumentation/TestMonitoredCounterGroup.java 0a730e9

Diff: https://reviews.apache.org/r/7112/diff/
Testing
-------
Thanks,

Ted Malaska