-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9279/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've extended the system to support validations on form level.
This addresses bug SQOOP-858.
    https://issues.apache.org/jira/browse/SQOOP-858
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 753d78e74a3d632e27cd9a965efa79031de5c7d8
  common/src/main/java/org/apache/sqoop/model/FormUtils.java 10e64a3515437aa4f3522b7fa6d58d0e0f8a388d
  common/src/main/java/org/apache/sqoop/validation/Validation.java ddc1d9e1f302d09ab94f31f005f5883a1ebd9387
  common/src/test/java/org/apache/sqoop/validation/TestValidation.java 600cfff8c9c982cac9c98a63700bedfed09dfa9a
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 8980b629982e866949f5f92d9728045722ed156a
  connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 0372911a139c2a6d62ca8353976a527e55bc078d

Diff: https://reviews.apache.org/r/9279/diff/
Testing
-------

Unit tests seems to be passing and I've tried several scenarios on real cluster.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9279/#review16194
-----------------------------------------------------------

common/src/main/java/org/apache/sqoop/validation/Validation.java
<https://reviews.apache.org/r/9279/#comment34625>

    isEmpty() is redundant in this expression, isn't it?

common/src/test/java/org/apache/sqoop/validation/TestValidation.java
<https://reviews.apache.org/r/9279/#comment34628>

    Can you please update the message? Now assert fails rather than a NPE is thrown, right?

common/src/test/java/org/apache/sqoop/validation/TestValidation.java
<https://reviews.apache.org/r/9279/#comment34627>

    Isn't this test case redundant? The next test case covers whether SqoopException is thrown or not, doesn't it?
- Cheolsoo Park
On Feb. 3, 2013, 7:36 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9279/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2013, 7:36 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've extended the system to support validations on form level.
>
>
> This addresses bug SQOOP-858.
>     https://issues.apache.org/jira/browse/SQOOP-858
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 753d78e74a3d632e27cd9a965efa79031de5c7d8
>   common/src/main/java/org/apache/sqoop/model/FormUtils.java 10e64a3515437aa4f3522b7fa6d58d0e0f8a388d
>   common/src/main/java/org/apache/sqoop/validation/Validation.java ddc1d9e1f302d09ab94f31f005f5883a1ebd9387
>   common/src/test/java/org/apache/sqoop/validation/TestValidation.java 600cfff8c9c982cac9c98a63700bedfed09dfa9a
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 8980b629982e866949f5f92d9728045722ed156a
>   connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 0372911a139c2a6d62ca8353976a527e55bc078d
>
> Diff: https://reviews.apache.org/r/9279/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tried several scenarios on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

> On Feb. 6, 2013, 7:47 p.m., Cheolsoo Park wrote:
> >

Hi Cheolsoo,
thank you very much for your review!
> On Feb. 6, 2013, 7:47 p.m., Cheolsoo Park wrote:
> > common/src/main/java/org/apache/sqoop/validation/Validation.java, line 185
> > <https://reviews.apache.org/r/9279/diff/1/?file=254985#file254985line185>
> >
> >     isEmpty() is redundant in this expression, isn't it?

I believe that it's not redundant. Allowed states are:

* form
* form.input

Form name can't be empty, but "".split(".") will return array with one entry and thus I believe that I need to filter that out.
> On Feb. 6, 2013, 7:47 p.m., Cheolsoo Park wrote:
> > common/src/test/java/org/apache/sqoop/validation/TestValidation.java, lines 96-102
> > <https://reviews.apache.org/r/9279/diff/1/?file=254986#file254986line96>
> >
> >     Isn't this test case redundant? The next test case covers whether SqoopException is thrown or not, doesn't it?

I agree that it's redundant, I'll remove it in my next patch.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9279/#review16194
-----------------------------------------------------------
On Feb. 3, 2013, 7:36 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9279/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2013, 7:36 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've extended the system to support validations on form level.
>
>
> This addresses bug SQOOP-858.
>     https://issues.apache.org/jira/browse/SQOOP-858
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 753d78e74a3d632e27cd9a965efa79031de5c7d8
>   common/src/main/java/org/apache/sqoop/model/FormUtils.java 10e64a3515437aa4f3522b7fa6d58d0e0f8a388d
>   common/src/main/java/org/apache/sqoop/validation/Validation.java ddc1d9e1f302d09ab94f31f005f5883a1ebd9387
>   common/src/test/java/org/apache/sqoop/validation/TestValidation.java 600cfff8c9c982cac9c98a63700bedfed09dfa9a
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 8980b629982e866949f5f92d9728045722ed156a
>   connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 0372911a139c2a6d62ca8353976a527e55bc078d
>
> Diff: https://reviews.apache.org/r/9279/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tried several scenarios on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9279/
-----------------------------------------------------------

(Updated Feb. 6, 2013, 8:09 p.m.)
Review request for Sqoop.
Changes
-------

I've incorporated Cheolsoo's changes.
Description
-------

I've extended the system to support validations on form level.
This addresses bug SQOOP-858.
    https://issues.apache.org/jira/browse/SQOOP-858
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 753d78e74a3d632e27cd9a965efa79031de5c7d8
  common/src/main/java/org/apache/sqoop/model/FormUtils.java 10e64a3515437aa4f3522b7fa6d58d0e0f8a388d
  common/src/main/java/org/apache/sqoop/validation/Validation.java ddc1d9e1f302d09ab94f31f005f5883a1ebd9387
  common/src/test/java/org/apache/sqoop/validation/TestValidation.java 600cfff8c9c982cac9c98a63700bedfed09dfa9a
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 8980b629982e866949f5f92d9728045722ed156a
  connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 0372911a139c2a6d62ca8353976a527e55bc078d

Diff: https://reviews.apache.org/r/9279/diff/
Testing
-------

Unit tests seems to be passing and I've tried several scenarios on real cluster.
Thanks,

Jarek Cecho

> On Feb. 6, 2013, 7:47 p.m., Cheolsoo Park wrote:
> > common/src/main/java/org/apache/sqoop/validation/Validation.java, line 185
> > <https://reviews.apache.org/r/9279/diff/1/?file=254985#file254985line185>
> >
> >     isEmpty() is redundant in this expression, isn't it?
>
> Jarek Cecho wrote:
>     I believe that it's not redundant. Allowed states are:
>    
>     * form
>     * form.input
>    
>     Form name can't be empty, but "".split(".") will return array with one entry and thus I believe that I need to filter that out.

You're right. I read it wrong as "parts.isEmpty()" instead of "formInput.isEmpty()". Thanks!
- Cheolsoo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9279/#review16194
-----------------------------------------------------------
On Feb. 6, 2013, 8:09 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9279/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 8:09 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've extended the system to support validations on form level.
>
>
> This addresses bug SQOOP-858.
>     https://issues.apache.org/jira/browse/SQOOP-858
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 753d78e74a3d632e27cd9a965efa79031de5c7d8
>   common/src/main/java/org/apache/sqoop/model/FormUtils.java 10e64a3515437aa4f3522b7fa6d58d0e0f8a388d
>   common/src/main/java/org/apache/sqoop/validation/Validation.java ddc1d9e1f302d09ab94f31f005f5883a1ebd9387
>   common/src/test/java/org/apache/sqoop/validation/TestValidation.java 600cfff8c9c982cac9c98a63700bedfed09dfa9a
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 8980b629982e866949f5f92d9728045722ed156a
>   connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 0372911a139c2a6d62ca8353976a527e55bc078d
>
> Diff: https://reviews.apache.org/r/9279/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tried several scenarios on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9279/#review16204
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Feb. 6, 2013, 8:09 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9279/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 8:09 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've extended the system to support validations on form level.
>
>
> This addresses bug SQOOP-858.
>     https://issues.apache.org/jira/browse/SQOOP-858
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java 753d78e74a3d632e27cd9a965efa79031de5c7d8
>   common/src/main/java/org/apache/sqoop/model/FormUtils.java 10e64a3515437aa4f3522b7fa6d58d0e0f8a388d
>   common/src/main/java/org/apache/sqoop/validation/Validation.java ddc1d9e1f302d09ab94f31f005f5883a1ebd9387
>   common/src/test/java/org/apache/sqoop/validation/TestValidation.java 600cfff8c9c982cac9c98a63700bedfed09dfa9a
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 8980b629982e866949f5f92d9728045722ed156a
>   connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 0372911a139c2a6d62ca8353976a527e55bc078d
>
> Diff: https://reviews.apache.org/r/9279/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tried several scenarios on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>