Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - whitespace


Copy link to this message
-
Re: whitespace
Joel Koshy 2012-09-18, 22:52
I'm also obsessive compulsive and prefer B.

Joel

On Tue, Sep 18, 2012 at 3:01 PM, Prashanth Menon <[EMAIL PROTECTED]
> wrote:

> I prefer A, but go with C only when iterating over certain collections
> (maps/tuples etc) to take advantage of Scala's destructuring capabilities;
> in these case the spaced brackets make it easier to read.
>
> - Prashanth
>
> On Tue, Sep 18, 2012 at 5:42 PM, Neha Narkhede <[EMAIL PROTECTED]
> >wrote:
>
> > Prefer A, but ok with B.
> >
> > Thanks,
> > Neha
> >
> > On Tue, Sep 18, 2012 at 2:35 PM, Jay Kreps <[EMAIL PROTECTED]> wrote:
> > > The original code was in the style
> > >    for(x <- lst) {..}
> > > A lot of newer code looks like
> > >    for (x <- lst) {...}
> > > Some code also occasionally does
> > >    for ( x <- lst ) {...}
> > >
> > > This is not a big deal but because I am obsessive compulsive I must
> make
> > > all whitespace in a given file consistent. This results in big patches
> > with
> > > mostly trivial changes. Can we standardize on one of the above and
> > > opportunistically convert towards it?
> > >
> > > Let's call the above A, B, and C respectively. I vote for A, but am
> > pretty
> > > cool with B too.
> > >
> > > -Jay
> >
>