Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-663 Introduce connector SDK


Copy link to this message
-
Review Request: SQOOP-663 Introduce connector SDK
Jarek Cecho 2013-03-24, 23:53

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10106/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've created first cut of connector SDK and I would like to get other's feedback. I've created new maven module and put all forms and appropriate validations inside rather than having them inside the Generic JDBC Connector. I'm expecting that they will be heavily reused between various connectors.
This addresses bug SQOOP-663.
    https://issues.apache.org/jira/browse/SQOOP-663
Diffs
-----

  connector/connector-generic-jdbc/pom.xml 73161f0108d654064b0abfca57ca2d6f100d1049
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java 23f19b5fdfe4134eb621d1ecb0fff08379abb7c1
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 40a777499492a3b18f1fee1fd96222c77b8868ce
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java d54b43021fc6f8554978ec284f52159951de44f9
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 3e9789c35e1e56d53d30257801cc8ce6194bbc0c
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 4e24517f0c1242bdcf105fc4d77c19d2673e4cd6
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java 6061600b8ce2d302a1ef69279b38f6f06508d0a5
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionForm.java c35449460e63ebbe3f999dc4853ad829db208b82
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java f2b2d656b623acebc74eb3899d0a7893c1be1907
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java ee4bb6e57d1abcc4a9269d93e6384d9f2c315a1c
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java f3c1d13c884c8a91d74af62e43fe8547c4961d54
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java 3422a8fa28c0a594e4eb454f46fe73f6760d81ba
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/constant/SdkConstants.java PRE-CREATION
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ConnectionForm.java PRE-CREATION
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ExportTableForm.java PRE-CREATION
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ImportTableForm.java PRE-CREATION
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/validation/ValidationUtil.java PRE-CREATION
  connector/pom.xml 68969a0ab284bc760ff5cc5a371523c8e5683d8f
  pom.xml 25dfba6cbf839f5139dec93c10cf746434847acf

Diff: https://reviews.apache.org/r/10106/diff/
Testing
-------

Integration and unit tests seems to be passing.
Thanks,

Jarek Cecho